Closed Bug 1602593 Opened 2 years ago Closed 2 years ago

osclientcert OS operations need to happen on a single thread

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

(Blocks 1 open bug)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

According to Sleevi [0], in practice it is not safe to use the OS APIs we're using across more than one thread. We should be able to handle this by having a dedicated thread with synchronous dispatch.

[0] https://twitter.com/sleevi_/status/1197974017329782786

The OS APIs used by the osclientcerts module aren't guaranteed to be
thread-safe. To deal with this, this patch introduces a dedicated thread to
perform these operations.

Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dff95dfb600
add dedicated thread for osclientcerts OS API calls r=jcj
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Depends on: 1694464
You need to log in before you can comment on or make changes to this bug.