Closed Bug 1602611 Opened 4 years ago Closed 4 years ago

ubuntu1804 - ubuntu1804 - browser/base/content/test/general/browser_menuButtonFitts.js | Test timed out -

Categories

(Firefox :: General, defect, P5)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

References

Details

Attachments

(2 files)

Bug 1602611 - mark browser_menuButtonFitts.js as a skipped test on ubuntu1804
47 bytes, text/x-phabricator-request
Details | Review
Bug 1602611 - fix browser_menuButtonFitts.js to wait for resizes on Linux, r?jaws
47 bytes, text/x-phabricator-request
Details | Review

Filed by: egao [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=280349959&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Vh5IjRn0Tkq_4_eKISZ4ZQ/runs/0/artifacts/public/logs/live_backing.log

suite: mochitest-browser-chrome
chunk: 3

context:
[task 2019-12-09T19:49:56.803Z] 19:49:56 INFO - checking window state
[task 2019-12-09T19:49:56.811Z] 19:49:56 INFO - TEST-START | browser/base/content/test/general/browser_menuButtonFitts.js
[task 2019-12-09T19:50:41.883Z] 19:50:41 INFO - TEST-INFO | started process screentopng
[task 2019-12-09T19:50:42.193Z] 19:50:42 INFO - TEST-INFO | screentopng: exit 0
[task 2019-12-09T19:50:42.193Z] 19:50:42 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_menuButtonFitts.js | Test timed out -
[task 2019-12-09T19:50:42.193Z] 19:50:42 INFO - GECKO(2177) | MEMORY STAT | vsize 3641MB | residentFast 404MB | heapAllocated 137MB
[task 2019-12-09T19:50:42.193Z] 19:50:42 INFO - TEST-OK | browser/base/content/test/general/browser_menuButtonFitts.js | took 45083ms
[task 2019-12-09T19:50:42.193Z] 19:50:42 INFO - checking window state

This is a new permafail that can be observed when run in ubuntu1804.

Currently, the expected timeline for migrating to ubuntu1804 is end of December 2019.

:dolske - seeing that Jared is on parental leave until after the expected migration date, would it be acceptable to have this test either skip-if or fail-if on ubuntu1804?

Flags: needinfo?(dolske)
Keywords: intermittent-failure
Summary: Intermittent ubuntu1804 - browser/base/content/test/general/browser_menuButtonFitts.js | Test timed out - → ubuntu1804 - ubuntu1804 - browser/base/content/test/general/browser_menuButtonFitts.js | Test timed out -

I've marked the test as a permanent failure in this try run:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1%2C2%2C3&revision=b8991d4c39d59bfb0908879c120f985555a0bf6d

However, oddly the test produces both TEST-UNEXPECTED-FAIL and TEST-UNEXPECTED-PASS which is confusing:

[task 2019-12-18T20:13:32.193Z] 20:13:32     INFO - TEST-START | browser/base/content/test/general/browser_menuButtonFitts.js
[task 2019-12-18T20:14:17.283Z] 20:14:17     INFO - TEST-INFO | started process screentopng
[task 2019-12-18T20:14:17.570Z] 20:14:17     INFO - TEST-INFO | screentopng: exit 0
[task 2019-12-18T20:14:17.570Z] 20:14:17     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_menuButtonFitts.js | Test timed out - 
[task 2019-12-18T20:14:17.572Z] 20:14:17     INFO - TEST-UNEXPECTED-PASS | browser/base/content/test/general/browser_menuButtonFitts.js | We expect at least one assertion to fail because this test file is marked as fail-if in the manifest. - 
[task 2019-12-18T20:14:17.572Z] 20:14:17     INFO - TEST-INFO | expected FAIL
[task 2019-12-18T20:14:17.572Z] 20:14:17     INFO - GECKO(2973) | MEMORY STAT | vsize 3630MB | residentFast 401MB | heapAllocated 134MB
[task 2019-12-18T20:14:17.572Z] 20:14:17     INFO - TEST-OK | browser/base/content/test/general/browser_menuButtonFitts.js | took 45094ms
[task 2019-12-18T20:14:17.572Z] 20:14:17     INFO - checking window state

Thus I've decided to mark this test with a skip-if in this push:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=281787656&tier=1%2C2%2C3&revision=69aae1e32d49b66f82c5633cad735bc43204cb72

Assignee: nobody → egao
Status: NEW → ASSIGNED

Leaving open so that sometime down the line I can return and see if the test passes.

Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7953b6697a4
mark browser_menuButtonFitts.js as a skipped test on ubuntu1804 r=jmaher
Flags: needinfo?(dolske) → needinfo?(gijskruitbosch+bugs)

Gonna steal this to actually fix the issue and re-enable the test given try was green.

Assignee: egao → gijskruitbosch+bugs
Flags: needinfo?(gijskruitbosch+bugs)

Jared, I think you're back? Phab thinks you're not around for another 2 weeks; let me know if I should find another reviewer.

Flags: needinfo?(jaws)

(In reply to :Gijs (he/him) from comment #9)

Gonna steal this to actually fix the issue and re-enable the test given try was green.

Gah, so I'm wrong, because the trypush didn't deliver, it seems? How am I supposed to request these jobs? I tried adding new jobs but filtering for "add new tests", even with "use full job list", for "1804 mochitest browser" only finds me mochitest screenshot jobs somehow. How am I meant to run this configuration?

Flags: needinfo?(jmaher)

I'm back now, I've fixed phabricator so it won't show that anymore. Thanks for letting me know.

Flags: needinfo?(jaws)

browser chrome tests haven't moved to 1804 yet, there are a couple tests that are in the queue to be greened up

Flags: needinfo?(jmaher)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #14)

browser chrome tests haven't moved to 1804 yet, there are a couple tests that are in the queue to be greened up

I don't really follow - comment #3 has links to a trypush with failing tests. How do I do the same / a similar trypush so I can work out if my patch fixes this issue in an 1804 environment so we don't switch to 1804 with this test disabled?

Flags: needinfo?(jmaher)

here is a more recent try push changeset that has changes needed to run 1804 on try for browser-chrome:
https://hg.mozilla.org/try/rev/6915b67794fcb1f8bd0d9e19669117281afc21d7

do ping if you have more problems/questions- I would like to help you keep unblocked.

Flags: needinfo?(jmaher)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #16)

here is a more recent try push changeset that has changes needed to run 1804 on try for browser-chrome:
https://hg.mozilla.org/try/rev/6915b67794fcb1f8bd0d9e19669117281afc21d7

do ping if you have more problems/questions- I would like to help you keep unblocked.

Thanks! It worked ( https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f48f0fe9b653460e20c453be6fc0737a5b0e6d3 ) , so I landed the changes and un-disabled the test for 18.04. Let me know if somehow this test does go orange again.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/12cf973efefe
fix browser_menuButtonFitts.js to wait for resizes on Linux, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: