1602615 - Sometimes drag and drop of URLs causes flicker

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:

1. Make sure that <localProfileDir\shortcutCache> is empty. I could not find a way to clear this cache from Firefox UI. I deleted icon files directly using File Explorer.
2. Navigate to any websites that have a favicon <such as http://mozilla.org>.
3. Drag the lock icon from the URL bar to the desktop.

Actual result:
A shortcut to the website will be created with flickering all Windows.

Expected result:
The shortcut should be created, but flickering should not happen.

This flicker is caused because we broadcast a message to update the shortcut icon after we created a favicon image. (See bug 110894.)

Comment 1

[Masatoshi Kimura [:emk]]

I'm using drag and drop very frequently, so this bug is really annoying.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1602615 - Add a callback parameter to ObtainCachedIconFile and use it in GetFileContentsInternetShortcut. r?jmathies

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 1602615 - Add a support for free-threaded IStream to handle Internet shortcuts. r?jmathies

By making the IStream object free-threaded (or "agile"), IStream::Read will be
called off the main thread. So we can wait until favicon is created.

Depends on D56478

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba63fdaa83ba
Add a callback parameter to ObtainCachedIconFile and use it in GetFileContentsInternetShortcut. r=jmathies
https://hg.mozilla.org/integration/autoland/rev/4010545f6193
Add a support for free-threaded IStream to handle Internet shortcuts. r=jmathies

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ba63fdaa83ba
https://hg.mozilla.org/mozilla-central/rev/4010545f6193