1602692 - Enable a11y browser tests depending on takeFocus for Fission

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P2)

Description

[Chris Peterson [:cpeterson]]

a11y mochitest status as of 2019-12-10:

Test	Opt Status	Debug Status
accessible/tests/browser/e10s/browser_caching_attributes.js	skipped	skipped
accessible/tests/browser/e10s/browser_caching_value.js	skipped	skipped
accessible/tests/browser/e10s/browser_events_caretmove.js	skipped	skipped
accessible/tests/browser/e10s/browser_treeupdate_select_dropdown.js	skipped	skipped

Jamie says these tests are blocked on SetFocus bug 1556627.

Comment 1

[Chris Peterson [:cpeterson]]

Jamie says this bug depends on DOM bug 1556627, which is actively being worked on. Once that gets fixed, Jamie can assign this bug based on availability at the time; it should hopefully just be a matter of enabling the tests.

Comment 2

[Chris Peterson [:cpeterson]]

Jamie, just a heads up: nsFocusManager::SetFocus bug 1556627 has been fixed, so you might now be able to re-enable the a11y browser tests that depend on takeFocus.

Comment 3

[James Teh [:Jamie]]

Unfortunately, I get a whole stack of failures when I re-enable them. I'm looking into it further, but I think more work is going to be needed here. :(

Comment 4

[James Teh [:Jamie]]

Turns out most of the failures I was seeing were somehow related to AccessibleHandler. That's not ideal, but it's also not Fission specific.

Comment 5

[James Teh [:Jamie]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=18c477b6fb0d9c94fb412065e75a57cb8806347a

Comment 6

[James Teh [:Jamie]]

Attachment: Bug 1602692: Enable a11y tests for Fission which depend on TakeFocus.

nsFocusManager::SetFocus (and thus Accessible::TakeFocus) was fixed for Fission in bug 1556627.
Most of these tests now pass without modification.
browser_caching_value.js needed to be tweaked slightly to synthesize a key in the OOP iframe instead of the top level document.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c0e2ca40919
Enable a11y tests for Fission which depend on TakeFocus. r=yzen

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8c0e2ca40919