Closed Bug 1602692 Opened 4 years ago Closed 4 years ago

Enable a11y browser tests depending on takeFocus for Fission

Categories

(Core :: Disability Access APIs, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla75
Fission Milestone M4.1
Tracking Status
firefox75 --- fixed

People

(Reporter: cpeterson, Assigned: Jamie)

References

Details

Attachments

(1 file)

a11y mochitest status as of 2019-12-10:

Test Opt Status Debug Status
accessible/tests/browser/e10s/browser_caching_attributes.js skipped skipped
accessible/tests/browser/e10s/browser_caching_value.js skipped skipped
accessible/tests/browser/e10s/browser_events_caretmove.js skipped skipped
accessible/tests/browser/e10s/browser_treeupdate_select_dropdown.js skipped skipped

Jamie says these tests are blocked on SetFocus bug 1556627.

Blocks: a11y-fission
Type: defect → task
Priority: -- → P2
Summary: Fix accessible/tests/browser for Fission → Fix a11y browser tests depending on takeFocus for Fission
Summary: Fix a11y browser tests depending on takeFocus for Fission → Enable a11y browser tests depending on takeFocus for Fission

Jamie says this bug depends on DOM bug 1556627, which is actively being worked on. Once that gets fixed, Jamie can assign this bug based on availability at the time; it should hopefully just be a matter of enabling the tests.

Jamie, just a heads up: nsFocusManager::SetFocus bug 1556627 has been fixed, so you might now be able to re-enable the a11y browser tests that depend on takeFocus.

Flags: needinfo?(jteh)

Unfortunately, I get a whole stack of failures when I re-enable them. I'm looking into it further, but I think more work is going to be needed here. :(

Turns out most of the failures I was seeing were somehow related to AccessibleHandler. That's not ideal, but it's also not Fission specific.

Flags: needinfo?(jteh)
Assignee: nobody → jteh
Status: NEW → ASSIGNED

nsFocusManager::SetFocus (and thus Accessible::TakeFocus) was fixed for Fission in bug 1556627.
Most of these tests now pass without modification.
browser_caching_value.js needed to be tweaked slightly to synthesize a key in the OOP iframe instead of the top level document.

Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c0e2ca40919
Enable a11y tests for Fission which depend on TakeFocus. r=yzen
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: