1602720 - Tidy up IonBuilder JSOP_INITELEM_ARRAY/JSOP_INITELEM_INC code

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Jan de Mooij [:jandem]]

I need this for bug 1601599 and by sharing most code for these two ops we will also be able to optimize a bit more.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1602720 part 1 - Make IonBuilder::initializeArrayElement take an MNewArray argument. r?tcampbell!

This removes the confusing isNewArray() check in that function. It's also
incorrect with other changes because it doesn't account for loop phis for
example.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1602720 part 2 - Make initializeArrayElement take an MDefinition* instead of size_t. r?tcampbell!

Just move the MConstant-creation code into the callers to simplify later changes.

Depends on D56529

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1602720 part 3 - Rename initializeArrayElement to initArrayElementFastPath. r?tcampbell!

Depends on D56531

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1602720 part 4 - Factor out jsop_initelem_array fast path code into initArrayElemTryFastPath. r?tcampbell!

No change in behavior.

Depends on D56532

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1602720 part 5 - Merge most code for JSOP_INITELM_INC and JSOP_INITELEM_ARRAY into initArrayElement. r?tcampbell!

We now have a shared code path to compile these ops.

JSOP_INITELEM_ARRAY gains IC support and JSOP_INITELEM_INC can potentially use the
fast path now.

Depends on D56533

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d444961b5e70
part 1 - Make IonBuilder::initializeArrayElement take an MNewArray argument. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/45276248e692
part 2 - Make initializeArrayElement take an MDefinition* instead of size_t. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/54f4fc55ea0d
part 3 - Rename initializeArrayElement to initArrayElementFastPath. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/374f85b25b59
part 4 - Factor out jsop_initelem_array fast path code into initArrayElemTryFastPath. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/bc40ad2f351b
part 5 - Merge most code for JSOP_INITELM_INC and JSOP_INITELEM_ARRAY into initArrayElement. r=tcampbell

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d444961b5e70
https://hg.mozilla.org/mozilla-central/rev/45276248e692
https://hg.mozilla.org/mozilla-central/rev/54f4fc55ea0d
https://hg.mozilla.org/mozilla-central/rev/374f85b25b59
https://hg.mozilla.org/mozilla-central/rev/bc40ad2f351b

Comment 8

[Marian Raiciof [:marauder]]

== Change summary for alert #24474 (as of Fri, 13 Dec 2019 08:43:32 GMT) ==

Improvements:

52% glterrain windows10-64-shippable-qr opt e10s stylo 2.38 -> 1.14
39% glterrain windows10-64-shippable-qr opt e10s stylo 2.18 -> 1.33
8% tp5o_scroll windows10-64-shippable-qr opt e10s stylo 1.82 -> 1.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24474