Unvisited bookmarks do not autocomplete with browser.urlbar.suggest.history = false
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | wontfix |
firefox72 | --- | wontfix |
firefox73 | --- | verified |
firefox74 | --- | verified |
People
(Reporter: ke5trel, Assigned: adw)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
STR:
- Set
browser.urlbar.suggest.history = false
. - Clear all history.
- Type "blog" in the address bar.
Expected:
Autocompletes to blog.nightly.mozilla.org
bookmark.
Actual:
Bookmark does not autocomplete despite browser.urlbar.suggest.bookmark
being enabled.
Visit the bookmark or enable browser.urlbar.suggest.history
and autocomplete works as expected.
Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e9c9a624d055b54cf65a5361f5261a2278ec6d3e&tochange=36e230321fd00eab502391f7a16aff4aef35364d
Regressed by Bug 1582234.
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
The test includes all combinations of suggest.history and suggest.bookmark. I wonder what's going wrong.
Comment 3•5 years ago
|
||
Getting late for a fix in 72 though if you land a fix in 73 and verify it, we could still consider uplift.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
With suggest.history && suggest.bookmark, we do:
HAVING host_frecency >= ${SQL_AUTOFILL_FRECENCY_THRESHOLD}
OR bookmarked
So bookmarks bypass the frecency threshold.
With !suggest.history && suggest.bookmark, we do:
HAVING host_frecency >= ${SQL_AUTOFILL_FRECENCY_THRESHOLD}
AND bookmarked
So bookmarks are subject to the frecency threshold, which is inconsistent with the previous case.
Before bug 1582234, we did this for !suggest.history && suggest.bookmark:
WHERE bookmarked
HAVING host_frecency >= ${SQL_AUTOFILL_FRECENCY_THRESHOLD}
OR bookmarked
So this is indeed a regression from bug 1582234, but it doesn't show up until a bookmark falls below the frecency threshold, and maybe that's why the test doesn't catch it. (Or of course maybe the test is wrong too.)
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
Updated•5 years ago
|
Comment 9•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
Comment on attachment 9119934 [details]
Bug 1602728 - Always autofill bookmarks when suggest.history=false and suggest.bookmark=true regardless of frecency threshold.
Beta/Release Uplift Approval Request
- User impact if declined: Unvisited bookmarks sometimes will not be autofilled.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Please see comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a small tweak to the autofill SQL code, so it doesn't affect anything else. Autofill is very well tested in our automated tests.
- String changes made/needed:
Comment 11•5 years ago
|
||
Comment on attachment 9119934 [details]
Bug 1602728 - Always autofill bookmarks when suggest.history=false and suggest.bookmark=true regardless of frecency threshold.
Fixes an autofill regression. Thanks for including new tests. Approved for 73.0b5.
Comment 12•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Comment 13•5 years ago
|
||
I reproduced this issue using Fx 73.0a1 (2019-12-10) on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 74.0a1(latest) and Fx 73.0b5, on Windows 10 x64, Ubuntu 18.04 LTS and macOS 10.15.
Description
•