1602743 - Fix PowerPc build sys/auxv.h failure

Status: RESOLVED DUPLICATE of bug 1602386

(NSS :: Build, defect, P1)

Description

[Giulio Benetti]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36

Steps to reproduce:

Build with PowerPc without sys/auxv.h header

Actual results:

Failed with:
http://autobuild.buildroot.net/results/8bf95bd8a0aec8c53889308ab1e00d0a94f53d57/build-end.log

Comment 1

[Giulio Benetti]

Attachment: 0004-Bug-1602743-Fix-PowerPc-build-sys-auxv.h-failure.patch

Comment 2

[Charlène Wendling]

Attachment: nss_348_powerpc_gcc4_getauxval.diff

I can reproduce it on OpenBSD/macppc (32-bits PowerPC only). This patch helps but also introduces an issue on this platform, we're still using GCC 4.2.1 as the base compiler there.

__has_include() does not work, it's GCC>=5 only. Based on Giulio Benetti's patch, Jeremie Courreges-Anglas found an already existing workaround for this issue, so he expanded it to powerpc, and modified the second check for <sys/auxv.h>.

Comment 3

[J.C. Jones [:jcj] (he/they)]

This is a duplicate of bug 1602386 at this point, and it seems like the patch in Phabricator at https://phabricator.services.mozilla.com/D56712 covers attachment 9117831 [details] [diff] [review], avoiding __has_include. I'm going to put the other bug's patch onto our CI and please provide comments there. Thanks!