1602757 - Fission content processes aren't prestarted

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

When starting a browser and navigating to an initial domain, it does not use any sort of prestarted process like is done in e10s mode - the prestarted 'web' process is not used.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

https://imgur.com/gallery/m5tYJL6
Results for imgur:
non-fission: https://perfht.ml/2E5wPpO
fission: https://perfht.ml/36ngHfr

and another run:
non-fission: https://perfht.ml/2LSfaGz
fission: https://perfht.ml/2LEB1km

These are focused on the keydown event to start browsing, after a startup with ./firefox -P profile -no-remote about:blank, local opt build

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: add preallocation cache for webIsolated (fission) processes r=smaug,nika

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Use a single preallocation cache for all remotetypes except file: r=smaug,nika

Depends on D69589

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Support multiple preallocated processes for fission r=smaug

Depends on D69590

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: (reenable) Caching one recycled e10s process if it was very short-lived r=smaug

Depends on D69591

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Add markers for process creation and change preallocation blocking to a counter r=smaug

Depends on D69592

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

FYI, to recap Riot/Matrix discussions, we have one preallocation queue used for all remote types (and e10s) other than file:. I added logs and profiler markers. Tuning may still be needed, but loading CNN (which by default causes 14 processes to be created for me) didn't hit an empty cache at any point on my (fast linux) desktop. We'll need to check it on Windows and Mac as well.

We also still allow short-duration e10s processes to be recycled and reused (only for remotetype=web (e10s)).

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Fix blocker handling when processes are destroyed and add logs r=smaug

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: review responses r=smaug,nika

Depends on D71265

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Second round of review responses r=nika

Will be folded for landing

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: clearonshutdown r=nika

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Remove origins from markers, other review changes r=nika

Depends on D72462

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Fix e10s process reuse cache and add debugs r=nika

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Block extension processes from using the preallocation queue r=nika

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Work around LookAndFeel not propagating to processes without tabs r=emilio

This is a workaround for bug 1638618

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Telemetry checks overrideUpdateChannel only at process startup r=chutten

Since this is checked only at startup, to ensure it propagates to all
content processes we have to ensure we shut down and restart all
preallocated or cached processes (though the process running the current
page won't restart)

Depends on D76187

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Add prealloc as a type for processes in about:support r=flod,nika

Depends on D76188

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33515632a7db
add preallocation cache for webIsolated (fission) processes r=nika,smaug
https://hg.mozilla.org/integration/autoland/rev/d9b4b2cffaa5
Fix e10s process reuse cache and add debugs r=nika
https://hg.mozilla.org/integration/autoland/rev/a0142f6bb65f
Block extension processes from using the preallocation queue r=nika
https://hg.mozilla.org/integration/autoland/rev/2c7bf6206bb4
Work around LookAndFeel not propagating to processes without tabs r=emilio
https://hg.mozilla.org/integration/autoland/rev/1c98ac1c4283
Telemetry checks overrideUpdateChannel only at process startup r=chutten
https://hg.mozilla.org/integration/autoland/rev/2556e3876602
Add prealloc as a type for processes in about:support r=flod,fluent-reviewers

Comment 19

[Natalia Csoregi [:nataliaCs]]

Backed out for browser-chrome failures on browser_resource_uri.js

backout: https://hg.mozilla.org/integration/autoland/rev/7aaac87105b7e87c636057fec87311f60c50dd76

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=2556e38766026aa09aa8a2a5897120ea6e3a5c8c&searchStr=browser-chrome&selectedTaskRun=Z0Wr_HIVQjqSHMEchkZJrw-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303178830&repo=autoland&lineNumber=49254

[task 2020-05-21T00:30:42.500Z] 00:30:42 INFO - GECKO(1448) | [Child 5984: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0B747800) [pid = 5984] [serial = 12] [outer = 00000000] [url = moz-extension://cec7b220-8b5d-48ba-a7ba-c38f39ff00d7/_generated_background_page.html]
[task 2020-05-21T00:31:59.519Z] 00:31:59 INFO - TEST-INFO | started process screenshot
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO - TEST-INFO | screenshot: exit 0
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO - Buffered messages logged at 00:30:29
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO - Entering test bound
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO - Console message: [JavaScript Error: "uncaught exception: undefined" {file: "resource://l10n-test/test.html" line: 26}]
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO - document.testsReadyPromise</<@resource://l10n-test/test.html:26:16
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO - async*document.testsReadyPromise<@resource://l10n-test/test.html:11:16
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO - @resource://l10n-test/test.html:8:34
[task 2020-05-21T00:31:59.586Z] 00:31:59 INFO -
[task 2020-05-21T00:31:59.587Z] 00:31:59 INFO - Buffered messages finished
[task 2020-05-21T00:31:59.587Z] 00:31:59 INFO - TEST-UNEXPECTED-FAIL | dom/l10n/tests/mochitest/document_l10n/non-system-principal/browser_resource_uri.js | Test timed out -
[task 2020-05-21T00:31:59.587Z] 00:31:59 INFO - GECKO(1448) | MEMORY STAT | vsize 811MB | vsizeMaxContiguous 372MB | residentFast 225MB | heapAllocated 86MB
[task 2020-05-21T00:31:59.587Z] 00:31:59 INFO - TEST-OK | dom/l10n/tests/mochitest/document_l10n/non-system-principal/browser_resource_uri.js | took 90079ms
[task 2020-05-21T00:31:59.587Z] 00:31:59 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-21T00:31:59.587Z] 00:31:59 INFO - TEST-UNEXPECTED-FAIL | dom/l10n/tests/mochitest/document_l10n/non-system-principal/browser_resource_uri.js | Found a tab after previous test timed out: resource://l10n-test/test.html -
[task 2020-05-21T00:31:59.594Z] 00:31:59 INFO - GECKO(1448) | [Child 3904: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 00FA6C00 == 1 [pid = 3904] [id = {70b5f5a6-b4e3-4194-8c58-399dc43f9261}]
[task 2020-05-21T00:31:59.594Z] 00:31:59 INFO - GECKO(1448) | [Child 3904, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/widget/windows/nsLookAndFeel.cpp, line 855
[task 2020-05-21T00:31:59.594Z] 00:31:59 INFO - GECKO(1448) | [Child 3904: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (00F68EF0) [pid = 3904] [serial = 1] [outer = 00000000]
[task 2020-05-21T00:31:59.597Z] 00:31:59 INFO - GECKO(1448) | [Child 3904: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (072C7400) [pid = 3904] [serial = 2] [outer = 00F68EF0]
[task 2020-05-21T00:31:59.624Z] 00:31:59 INFO - checking window state

Other failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303183355&repo=autoland&lineNumber=4206

[task 2020-05-21T00:39:51.001Z] 00:39:51 INFO - TEST-UNEXPECTED-FAIL | dom/ipc/tests/browser_ProcessPriorityManager.js | Uncaught exception - Waiting for browser at about:blank to reach priority BACKGROUND - timed out after 50 tries.

Comment 20

[Natalia Csoregi [:nataliaCs]]

Assertion: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303186489&repo=autoland&lineNumber=20557

Comment 21

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly M6a because this is an important performance bug and Jesup is actively working on it.

Comment 22

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: Don't keep cached e10s processes in the contentparent list r=nika

Also set process priority to BACKGROUND for processes moved into the cache

Depends on D76189

Comment 23

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1602757: disable process caching/preallocation while testing browser_resource_uri r=zbraniecki

Depends on D76533

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7d7edf158a4
add preallocation cache for webIsolated (fission) processes r=nika,smaug
https://hg.mozilla.org/integration/autoland/rev/1c6a6bfaaeef
Telemetry checks overrideUpdateChannel only at process startup r=chutten
https://hg.mozilla.org/integration/autoland/rev/32851bed1929
Add prealloc as a type for processes in about:support r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/232da017dc6a
disable process caching/preallocation while testing browser_resource_uri r=zbraniecki

Comment 25

[Narcis Beleuzu [:NarcisB]]

Backed out for marionette failures on test_crash.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/8912e3abc78133dbf7ffba380f3c80306780275a
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303496262&repo=autoland&lineNumber=48766

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd19c329c6b7
add preallocation cache for webIsolated (fission) processes r=nika,smaug
https://hg.mozilla.org/integration/autoland/rev/8bacf5ad656e
Telemetry checks overrideUpdateChannel only at process startup r=chutten
https://hg.mozilla.org/integration/autoland/rev/8dc7e11dbb9c
Add prealloc as a type for processes in about:support r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/9456c9f960c9
disable process caching/preallocation while testing browser_resource_uri r=zbraniecki

Comment 27

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failure on operator-dictionary-spacing-001.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/d0b1c0422e926a2aaa6259ce396467cb65642f74
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304127847&repo=autoland&lineNumber=2671

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5134aaa3278e
add preallocation cache for webIsolated (fission) processes r=nika,smaug
https://hg.mozilla.org/integration/autoland/rev/4b9c579de3b2
Telemetry checks overrideUpdateChannel only at process startup r=chutten
https://hg.mozilla.org/integration/autoland/rev/58ec60831af6
Add prealloc as a type for processes in about:support r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/383fd9b931ae
disable process caching/preallocation while testing browser_resource_uri r=zbraniecki

Comment 29

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failures on operator-dictionary-spacing-002/003/006.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/f519fea12dfc504e55daad335bfada4866383a02
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304196469&repo=autoland&lineNumber=1786

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35b752334888
add preallocation cache for webIsolated (fission) processes r=nika,smaug
https://hg.mozilla.org/integration/autoland/rev/6697644f94e1
Telemetry checks overrideUpdateChannel only at process startup r=chutten
https://hg.mozilla.org/integration/autoland/rev/98acb58a4479
Add prealloc as a type for processes in about:support r=flod,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/9f37745ea922
disable process caching/preallocation while testing browser_resource_uri r=zbraniecki

Comment 31

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/35b752334888
https://hg.mozilla.org/mozilla-central/rev/6697644f94e1
https://hg.mozilla.org/mozilla-central/rev/98acb58a4479
https://hg.mozilla.org/mozilla-central/rev/9f37745ea922