1602804 - Removing and setting a set/get watchpoint doesn't work after resuming execution

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P1)

Description

[jaril]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36

Steps to reproduce:

1. Open http://janodvarko.cz/tests/debugger/watchpoints/
2. Follow test case #1, and click the "Click Me!" button in step #2
3. Set a watchpoint (set) on the age property of the person object
4. Click Resume to pause on the watchpoint
5. Click Resume again to finish pausing and resume execution
6. Click on the "Click Me!" button again in test case #1, step #2
7. Click on the age property's watchpoint marker to remove the watchpoint
8. Try adding a set/get watchpoint

Actual results:

You should be able to put back the watchpoint after removing it.

Expected results:

Nothing happens.

Error:

JavaScript error: , line 0: uncaught exception: Protocol error (noSuchActor): No such actor for ID: server0.conn0.child1/obj78

Comment 1

[Miriam]

Interesting to note that if you step over and then try to add a watchpoint, it does work.

Comment 2

[jaril]

Attachment: Bug 1602804 - Don't demote object actors until the debugger resumes r=jlast

Comment 3

[Marcela (Please NI request to Brindusa Tot)]

I was able to reproduce on latest Nightly Version 73.0a1 Build ID 20191216214733 on Windows 10, macOS 10.15 and Ubuntu 18.04
Following the steps mentioned by the reporter, it is not possible to add a watchpoint after removing a previous one

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Raising the priority here since it breaks the feature.

The patch is attached, close to landing?

Honza

Comment 5

[jaril]

Attachment: Bug 1602804 - Create WatchpointMap to keep track of objects with watchpoints r=jlast

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cc5dce66033
Create WatchpointMap to keep track of objects with watchpoints r=jlast

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0cc5dce66033

Comment 8

[Marcela (Please NI request to Brindusa Tot)]

Verified - fixed on latest Nightly Version 73.0a1 Build ID 20191222215627 on Windows 10, Ubuntu 18-04 and macOS 10.15

Comment 9

[Julien Cristau [:jcristau]]

[Tracking Requested - why for this release]: It's not clear to me whether this blocks shipping watchpoints in 72.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift to beta if you think this is necessary for the feature to launch, and if it's not too risky?

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Jason, maybe you can help out with the uplift request?

Comment 12

[:Harald Kirschner :digitarald]

As Jason is out on holidays and this is a larger change late in the cycle, I'll mark this as wontfix for 72.

Comment 13

[Marcela (Please NI request to Brindusa Tot)]

I can confirm this issue is fixed. I verified on Windows 10, macOS 10.15 and Ubuntu 18.04. I'm updating the status flags since this issue is verified as fixed based on Comment 8.