1602910 - Memoize getBreakpointSources

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Jason Laster [:jlast]]

getBreakpointSources currently re-computes whenever the source list changes. This happens on popup preview and can be expensive for two reaons:

1. grouping breakpoints by source can take awhile for lots of bps and sources
2. re-render the breakpoints pane can be ~13 ms

We should try and avoid this

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1602910 - Memoize getBreakpointSources. r=bhackett

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e53756abfbfb
Memoize getBreakpointSources. r=bhackett

Comment 3

[Arthur Iakab [arthur_iakab]]

Backed out changeset e53756abfbfb (bug 1602910) for causing debugger test failures.

Backout revision https://hg.mozilla.org/integration/autoland/rev/6acff772bc417055ff63d7e41e830a01e069ac63

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=280935514&resultStatus=testfailed%2Cbusted%2Cexception&revision=e53756abfbfb57be63a8d40cbc7f11a6cfd761fc&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-debugger-tests%2Cnode%28debugger%29

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=280935514&repo=autoland

Jason can you please take a look?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47379e247e51
Memoize getBreakpointSources. r=bhackett

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/47379e247e51