Closed
Bug 1602914
Opened 6 years ago
Closed 6 years ago
[First Run Improvements] Refactor Triplets FirstRun.jsx getDerivedStateFromProps
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: pdahiya, Assigned: pdahiya)
References
Details
Attachments
(1 file)
getDerivedStateFromProps inside FirstRun.jsx updates current state after comparing message values from props. Comparing card ids + prevCardId concatenated strings to trigger updates in Triplets is not ideal
Refactor code inside getDerivedStateFromProps to better handle triggering first run ( triplets and interrupt ) updates
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
[Tracking Requested - why for this release]:
Assignee: nobody → pdahiya
Iteration: --- → 73.2 - Dec 16 - Jan 5
status-firefox73:
--- → affected
Priority: -- → P1
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0152641c5419
Refactor FirstRun interrupt and triplets update r=k88hudson
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in
before you can comment on or make changes to this bug.
Description
•