1602940 - Expose nsIUUIDGenerator on Services.jsm

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[:Gijs (he/him)]

As per summary. Services.uuid seems like it should work.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1602940: toolkit: expose nsIUUIDGenerator as Services.uuid;

By adding a shorthand for nsIUUIDGenerator to Services.jsm we can
avoid a lot of boilerplate code for a frequently used service.

Using nsIUUIDGenerator from JavaScript today normally looks something
like this:

const uuidGen = Cc["mozilla.org/uuid-generator;1"]
      .getService(Ci.nsIUUIDGenerator);
    uuidGen.generateUUID();

Which with this patch now be shortened to:

Services.uuid.generateUUID();

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1602940: xpcom: introduce nsIUUIDGenerator.generate();

By adding a new generate() method returning a string directly from
nsIUUIDGenerator we are able to avoid many cumbersome string coercions.

In JavaScript, string representations of UUIDs are more often than
not the requirement. This is usually to ease serialisation.

We may want to consider renaming nsIUUIDGenerator.generateUUID()
in the future to generateIDPtr() or similar, but this would require
a larger refactoring due to existing usage. It would be advisable
to make JS usage move to generate() first, before attempting a
rewrite of the C++ consumers.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

That shouldn't actually block beta.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1602940 - Add nsIUUIDGenerator to the Javascript Services object. r?Gijs!

This also adds a commented out option for automatically fixing use-services in the ESLint rule. This cannot be enabled at the moment as it needs special treatment for chrome tests.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1602940 - Automated replacements to use Services.uuid. r?Gijs!

Depends on D124391

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1602940 - Manual fixes to fix issues in files. r?Gijs!

Depends on D124392

Comment 7

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=0efccd4c746f50651c0221934b7a606066c71953

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9f9c4e0bb1d
Add nsIUUIDGenerator to the Javascript Services object. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d0ec1bb4c138
Automated replacements to use Services.uuid. r=Gijs,necko-reviewers,preferences-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/1ffad363c97e
Manual fixes to fix issues in files. r=Gijs,necko-reviewers,rpl,kershaw

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/b9f9c4e0bb1d
https://hg.mozilla.org/mozilla-central/rev/d0ec1bb4c138
https://hg.mozilla.org/mozilla-central/rev/1ffad363c97e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7855fef22513
fix Thunderbird consumers of nsIUUIDGenerator which is now in Services.jsm. rs=eslint