1602971 - log icon is jammed to job link

Status: RESOLVED FIXED

(Tree Management :: Push Health, defect)

Description

[alexander :surkov (:asurkov)]

no space between a log icon and job link, some margin between those would make nicer UI

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5795

Comment 2

[Cameron Dawson [:camd]]

Hey Alexander-- Would you take a look at the screenshot in the attached PR and let me know what you think? I can't tell if having the log link in a Tooltip is a good or bad idea. :) It cleans up the display of multiple jobs, though. Curious on your thoughts.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to Cameron Dawson [:camd] from comment #2)

Hey Alexander-- Would you take a look at the screenshot in the attached PR and let me know what you think? I can't tell if having the log link in a Tooltip is a good or bad idea. :) It cleans up the display of multiple jobs, though. Curious on your thoughts.

I like the popup. However if all it has is a log viewer link, then I'd say the old way perhaps is nicer, because you need to make only one click to see the logs. Also, not sure whether the popup provides a way to open a job in treeheader - this also is nice feature in current UI - I like to switch to treeherder UI to see a grid like structure of all jobs, it helps me to visually analyze how bad things are :) Having said that, if the popup will contain more info/links eventually - like screenshot link or links to appropriate tools like refanalyzer, etc, then I'd say it is worth to have.

Btw, 'bc6' link/button from your screenshot feels jammed to text, a space is wanted :)

Comment 4

[Cameron Dawson [:camd]]

Fixed by: https://github.com/mozilla/treeherder/pull/5795