1602973 - One can submit the same suggestion multiple times

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Théo Chevalier]

Not sure how this contributor managed to do this, but they managed to submit the very same suggestion twice here (Empty diff): https://pontoon.mozilla.org/fr/seamonkey/suite/chrome/mailnews/msgHdrViewOverlay.dtd/?string=129125

The project (and file) now shows one unreviewed string, but it leads to an empty list: https://pontoon.mozilla.org/fr/seamonkey/

Asking for some potential STRs

Comment 1

[Matjaz Horvat [:mathjazz]]

Both strings got submitted within a 10th of a second and are indeed exactly the same:

>>> ts = Translation.objects.filter(locale__code="fr", entity=129125)
>>> for t in ts:
...   t.date
... 
datetime.datetime(2019, 12, 10, 22, 16, 33, 895901, tzinfo=<UTC>)
datetime.datetime(2016, 11, 26, 17, 43, 15, 130000, tzinfo=<UTC>)
datetime.datetime(2019, 12, 10, 22, 16, 33, 883073, tzinfo=<UTC>)
>>> ts[0].string == ts[2].string
True

IIRC we had a check on Translate.Dead that disabled the Submit button while the request was running. We have a similar check on Translate.Next, but only for Review buttons I believe.

:adrian, could you take a look please?

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1521

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

adngdb merged PR #1521: "Fix bug 1602973 - Make sure users cannot send the same translation twice." in 6cc116b.