1603041 - Crash in [@ AllocInfo::Get<T> | moz_malloc_size_of | mozilla::webgl::ShaderValidatorResults::SizeOfIncludingThis]

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1468541 +++

This bug is for crash report bp-a7cb623e-cd0e-41e7-8301-5708b0191209.

Top 10 frames of crashing thread:

0 mozglue.dll AllocInfo::Get<1> memory/build/mozjemalloc.cpp:3047
1 mozglue.dll moz_malloc_size_of memory/mozalloc/mozalloc.cpp:128
2 xul.dll unsigned __int64 mozilla::webgl::ShaderValidatorResults::SizeOfIncludingThis dom/canvas/WebGLShaderValidator.cpp:485
3 xul.dll mozilla::WebGLShader::SizeOfIncludingThis dom/canvas/WebGLShader.cpp:302
4 xul.dll static __int64 mozilla::WebGLMemoryTracker::GetShaderSize dom/canvas/WebGLMemoryTracker.cpp:121
5 xul.dll nsresult mozilla::WebGLMemoryTracker::CollectReports dom/canvas/WebGLMemoryTracker.cpp:61
6 xul.dll nsresult mozilla::detail::RunnableFunction<`lambda at z:/task_1574352431/build/src/xpcom/base/nsMemoryReporterManager.cpp:1863:7'>::Run xpcom/threads/nsThreadUtils.h:564
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
8 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
9 xul.dll nsThread::Shutdown xpcom/threads/nsThread.cpp:900

Comment 1

[Gabriele Svelto [:gsvelto]]

This seems to have started with buildid 20190621214126 during the 69.0 cycle.

Comment 2

[Miko Mynttinen]

Attachment: Bug 1603041 - Remove WebGLContext from WebGLMemoryTracker before destroying resources r=jgilbert

Comment 3

[Miko Mynttinen]

I spotted a possible problem with the order of resource destruction and removing WebGLContext from WebGLMemoryTracker. This patch might not fix this bug.

Comment 4

[Kelsey Gilbert [:jgilbert]]

This will be fixed in Nightly by https://bugzilla.mozilla.org/show_bug.cgi?id=1477756.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d3256a2c780
Remove WebGLContext from WebGLMemoryTracker before destroying resources r=jgilbert

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0d3256a2c780

Comment 7

[Miko Mynttinen]

Jeff, do you think there is something to be done still, or can this bug be closed?

Comment 8

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9115226 [details]
Bug 1603041 - Remove WebGLContext from WebGLMemoryTracker before destroying resources r=jgilbert

This looks risk-free enough to uplift.

Comment 9

[Kelsey Gilbert [:jgilbert]]

Actually let's just let this ride.