outline-offset ignored on table elements since Firefox 71
Categories
(Core :: Layout: Tables, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox71 | --- | wontfix |
firefox72 | --- | verified |
firefox73 | --- | verified |
People
(Reporter: domischreib, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
198 bytes,
text/html
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:72.0) Gecko/20100101 Firefox/72.0
Steps to reproduce:
Since Firefox 71 (our tests first noticed the issue on 2019-12-04), outline-offset does no longer affect table elements:
div { outline: 1px solid red; outline-offset: 5px; } /* works /
table { outline: 1px solid red; outline-offset: 5px; } / doesn't work */
See https://codepen.io/dominikschreiber/pen/VwYaxRX for a minimal repro (or the attached file, which has the same content).
This also happens with Firefox 72.
Other browsers that support outline-offset (tested in Safari 13.0.4, Safari Technology Preview Revision 96, Chrome 79 Beta, and Chromium-based Edge 80 Canary) behave as expected
Actual results:
the outline on table elements is placed directly around the element (as if outline-offset:0 was set)
Expected results:
the outline on table elements should be placed 5px around the element (as specified by the stylesheet)
Comment 1•1 year ago
|
||
I can confirm this issue on the latest Nightly 73.0a1, Firefox 72 beta 7 and Firefox 71 - reproduced on Windows 10, Ubuntu 18.04 and Mac OS X 10.15.
I managed to find a regression range, here are the results:
-
last known build: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=340972ee99601a7932ed65ae040c1c8e3b984798&tochange=8d46f84b818dce78694859a991f328f2960cdc4e
Found commit message:
Bug 1482778 - Include captions within table outlines. r=dbaron
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
I guess we just need to inherit the offset from the table frame.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 3•1 year ago
|
||
outline-offset isn't included in the outline shorthand.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/12b52bc98c6f Inherit outline-offset from the table. r=dbaron
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20798 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 7•1 year ago
|
||
bugherder |
Assignee | ||
Comment 8•1 year ago
|
||
Comment on attachment 9116178 [details]
Bug 1603049 - Inherit outline-offset from the table. r=dbaron,heycam,#style
Beta/Release Uplift Approval Request
- User impact if declined: Some outlines in tables may look wrong.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: open attachment in the bug
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): simple css change.
- String changes made/needed: none
Assignee | ||
Updated•1 year ago
|
Comment 9•1 year ago
|
||
Comment on attachment 9116178 [details]
Bug 1603049 - Inherit outline-offset from the table. r=dbaron,heycam,#style
css regression fix, approved for 72.0b8
Updated•1 year ago
|
Comment 10•1 year ago
|
||
Verified as fixed on the latest Nightly 73.0a1 on Mac OS X 10.15, Ubuntu 18.04 and Windows 10 x64.
Upstream PR merged by moz-wptsync-bot
Comment 12•1 year ago
|
||
bugherderuplift |
Updated•1 year ago
|
Comment 13•1 year ago
|
||
Verified as fixed also on the latest Firefox 72 beta 8 - on Windows 10 x64, Ubuntu 18.04 and Mac OS X 10.15.
Description
•