1603049 - outline-offset ignored on table elements since Firefox 71

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[Dominik Schreiber]

Attachment: firefox-71-outline-offset-on-table-elements-repro.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Since Firefox 71 (our tests first noticed the issue on 2019-12-04), outline-offset does no longer affect table elements:

div { outline: 1px solid red; outline-offset: 5px; } /* works /
table { outline: 1px solid red; outline-offset: 5px; } / doesn't work */

See https://codepen.io/dominikschreiber/pen/VwYaxRX for a minimal repro (or the attached file, which has the same content).

This also happens with Firefox 72.

Other browsers that support outline-offset (tested in Safari 13.0.4, Safari Technology Preview Revision 96, Chrome 79 Beta, and Chromium-based Edge 80 Canary) behave as expected

Actual results:

the outline on table elements is placed directly around the element (as if outline-offset:0 was set)

Expected results:

the outline on table elements should be placed 5px around the element (as specified by the stylesheet)

Comment 1

[Simona Badau]

I can confirm this issue on the latest Nightly 73.0a1, Firefox 72 beta 7 and Firefox 71 - reproduced on Windows 10, Ubuntu 18.04 and Mac OS X 10.15.

I managed to find a regression range, here are the results:

• last known build: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=340972ee99601a7932ed65ae040c1c8e3b984798&tochange=8d46f84b818dce78694859a991f328f2960cdc4e

• first bad build: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b8364cfdb04bfdfde7c01589e48e24973c1ce9c&tochange=8d46f84b818dce78694859a991f328f2960cdc4e

Found commit message:
Bug 1482778 - Include captions within table outlines. r=dbaron

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I guess we just need to inherit the offset from the table frame.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1603049 - Inherit outline-offset from the table. r=dbaron,heycam,#style

outline-offset isn't included in the outline shorthand.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12b52bc98c6f
Inherit outline-offset from the table. r=dbaron

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20798 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/12b52bc98c6f

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9116178 [details]
Bug 1603049 - Inherit outline-offset from the table. r=dbaron,heycam,#style

Beta/Release Uplift Approval Request

• User impact if declined: Some outlines in tables may look wrong.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: open attachment in the bug
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): simple css change.
• String changes made/needed: none

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9116178 [details]
Bug 1603049 - Inherit outline-offset from the table. r=dbaron,heycam,#style

css regression fix, approved for 72.0b8

Comment 10

[Simona Badau]

Verified as fixed on the latest Nightly 73.0a1 on Mac OS X 10.15, Ubuntu 18.04 and Windows 10 x64.

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0999acce0209

Comment 13

[Simona Badau]

Verified as fixed also on the latest Firefox 72 beta 8 - on Windows 10 x64, Ubuntu 18.04 and Mac OS X 10.15.