1603100 - Remove unused declaration in U2F.cpp

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

These line seems to be unused:
https://searchfox.org/mozilla-central/source/dom/u2f/U2F.cpp#34

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by clang diag https://clang.llvm.org/docs/DiagnosticsReference.html#wunused-variable

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Mahak]

hello Sir,
according to the link, to clone the repo I used 'hg clone https://hg.mozilla.org/mozilla-central/' this command but this command does not contain the repo of given issue .

Comment 2

[Ash Tiwari]

Who do I put in the reviewer tag, i.e. "r="?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

(In reply to Mahak from comment #1)

according to the link, to clone the repo I used 'hg clone https://hg.mozilla.org/mozilla-central/' this command but this command does not contain the repo of given issue .

Sorry but I don't understand what you mean here?!

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Who do I put in the reviewer tag, i.e. "r="?

Please see: https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html#to-write-a-patch

Comment 5

[Mahak]

Attachment: Bug 1603100 is fixed

Comment 6

[Mahak]

Attachment: Bug 1603100 has removed the extra line ? Gabriele Svelto

Depends on D57058

Comment 7

[Ash Tiwari]

Attachment: Bug 1603100 - Removed an unused variable r?Ehsan

Comment 8

[Mahak]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Who do I put in the reviewer tag, i.e. "r="?

Please see: https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html#to-write-a-patch

Sir ,
I fixed the bug but why it is assigned to someone else ?
And Also I'm not able to find who is the reviewer .
Please help

Comment 9

[Ash Tiwari]

Attachment: Bug 1603100- Remove an unused variable. r?Ehsan

Comment 10

[Sylvestre Ledru [:Sylvestre]]

I fixed the bug but why it is assigned to someone else ?

Not sure. I set you as owner.

Ash, please don't take ongoing bugs from others. If you want another good first bug, please let me an email.

And Also I'm not able to find who is the reviewer ?

hg log will tell you

Comment 11

[Ash Tiwari]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #4)

Who do I put in the reviewer tag, i.e. "r="?

Please see: https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html#to-write-a-pat(In reply to Sylvestre Ledru [:Sylvestre] from comment #10)

I fixed the bug but why it is assigned to someone else ?

Not sure. I set you as owner.

Ash, please don't take ongoing bugs from others. If you want another good first bug, please let me an email.

And Also I'm not able to find who is the reviewer ?

hg log will tell you

Sorry, my bad. This bug wasn't assigned to anyone and then I was made the assignee so I thought I could work on it. Sorry again.
Mailing you for another bug.

Comment 12

[Mahak]

Attachment: U2F.cpp

Bug 1603100 removes the unused line r?Andrew Halberstadt

Comment 13

[Mahak]

Attachment: Bug 1603100 removes the unused line?Gabriele Svelto

Depends on D57059

Comment 14

[Mahak]

Sir,
I did use hg log and it displayed all the commits but how will I distinguish the reviewer from others ..
Could you please help me.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Mahak,
I am really sorry but I don't think you are ready yet to contribute to Firefox. All the information that you need to contribute are referenced on the doc.
I think you should probably start with easier projects (for example, hosted on github). Firefox isn't a trivial project to start contributing.

I unassigned the bug to you.

Comment 16

[Mahak]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #15)

Mahak,
I am really sorry but I don't think you are ready yet to contribute to Firefox. All the information that you need to contribute are referenced on the doc.
I think you should probably start with easier projects (for example, hosted on github). Firefox isn't a trivial project to start contributing.

I unassigned the bug to you.

Sir,
I understand what you are saying and I respect that you have answered so many silly questions.
I thank you for all and just want to ask from where should I start to contribute to open source and what are easy github projects ?

Comment 17

[Ash Tiwari]

(In reply to Mahak from comment #16)

(In reply to Sylvestre Ledru [:Sylvestre] from comment #15)

Mahak,
I am really sorry but I don't think you are ready yet to contribute to Firefox. All the information that you need to contribute are referenced on the doc.
I think you should probably start with easier projects (for example, hosted on github). Firefox isn't a trivial project to start contributing.

I unassigned the bug to you.

Sir,
I understand what you are saying and I respect that you have answered so many silly questions.
I thank you for all and just want to ask from where should I start to contribute to open source and what are easy github projects ?

If I may, https://github.com/MunGell/awesome-for-beginners could help. Very beginner-friendly.

Comment 18

[Mahak]

Attachment: D61417.diff

Comment 19

[Mahak]

I have submitted a patch as I thought No one was working on this .
I request for the review

Comment 20

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 9123966 [details] [diff] [review]
D61417.diff

Please use phabricator
see
https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html

Comment 21

[Mahak]

I have used the process given in the doc and have used phabricator.
Could you please point out where I'm going wrong?

Comment 22

[Sylvestre Ledru [:Sylvestre]]

Not sure how you did that wrong
but https://bug1603100.bmoattachments.org/attachment.cgi?id=9123966 is a bugzilla attachement, not a phab review

Comment 23

[Mahak]

Attachment: Bug 1603100 - Remove the unused line in U2F.cpp. r?sylvestre

Comment 24

[Mahak]

Attachment: Bug 1603100 - Remove the unused declaration in U2F.cpp. r?sylvestre

Comment 25

[Mahak]

I guess I have made the required changes .
@Sylvestre can you please review it?

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2614c67d7e65
Remove the unused line in U2F.cpp. r=sylvestre

Comment 27

[Mahak]

Thanks for the Motivation @sylvestre .
I just want to know when I show this as my contribution ,Does this make a difference that it is assigned to someone else?

Comment 28

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2614c67d7e65

Comment 29

[Julian Descottes [:jdescottes]]

(In reply to Mahak from comment #27)

Thanks for the Motivation @sylvestre .
I just want to know when I show this as my contribution ,Does this make a difference that it is assigned to someone else?

Phabricator automatically updated the assignee based on the patches that were uploaded on phabricator at that time. Restoring the field to the correct value.