Closed Bug 1603194 Opened 5 years ago Closed 5 years ago

nsDocShell::mAllowKeywordFixup isn't preserved across process switches

Categories

(Core :: DOM: Navigation, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M5
Tracking Status
firefox73 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

mAllowKeywordFixup is set using the INTERNAL_LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP from the nsDocShellLoadState.

If we process switch during a load, then we generate a new nsDocShellLoadState in the new process using CreateFromPendingChannel, but this doesn't have the load flags that the original one did.

We should also look for other data from the nsDocShellLoadState that gets copied into the docshell, not the channel, and make sure we preserve this across process-switches.

Assignee: nobody → matt.woodrow
Status: NEW → ASSIGNED
Type: defect → task
Fission Milestone: --- → M5
Priority: -- → P2
Attachment #9115324 - Attachment description: Bug 1603194 - Pass nsDocShellLoadStats's load flags to new process when process switching. r?kmag → Bug 1603194 - Pass nsDocShellLoadState's load flags to new process when process switching. r?kmag
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/748d2a318649
Pass nsDocShellLoadState's load flags to new process when process switching. r=kmag
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: