1603196 - process switching fires spurious nsIWebProgressListener events to RemoteWebProgress

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Matt Woodrow (:mattwoodrow)]

When we process switch we stop and destroy the old docshell, and create a new docshell in the new process.

Stopping the old docshell fires a STATE_STOP notification, and resuming the load in the new docshell fires a STATE_START notification. We also fire a START/STOP pair for the initial about:blank load in the new docshell.

These notifications probably make sense in the scope of their local process, but from the perspective of RemoteWebProgress in the parent, we probably want to suppress them, since it's all one logical load.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1603196 - Skip START_STOP notifications from old process being delivered to RemoteWebProgress when process switching during a load. r?kmag

This doesn't block the STATE_START notification from the new process, as we currently have a second start notification (when DocumentChannel redirects to the real channel), so this is unchanged.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mattwoodrow, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf551ae8dece
Skip START_STOP notifications from old process being delivered to RemoteWebProgress when process switching during a load. r=kmag,nika

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bf551ae8dece