1603200 - crhirt.blogspot.com and www.ssvwv.com versus pop-up blocking

Status: RESOLVED DUPLICATE of bug 1352332

(Core :: DOM: Push Subscriptions, enhancement)

Description

[Graham Perrin]

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:56.0) Gecko/20100101 Firefox/56.0 Waterfox/56.3

Steps to reproduce:

1. visit https://crhirt.blogspot.com/2019/01/how-to-use-system-spell-checker.html
2. scroll

Actual results:

3. insecure http://www.ssvwv.com/ opens in a new window
4. bring the blogspot.com page to the foreground
5. again, scroll
6. http://www.ssvwv.com/ opens in another new window

… and so on.

Expected results:

3. pop-up blocking

Comment 1

[Graham Perrin]

Attachment: Screen recording

In this test, it seeed that the blocker began taking effect whilst the fourth non-blocked window was appearing.

Comment 2

[Florencia Di Ciocco, NI to vbalducci]

Hi Nakota,

I was unable to reproduce this issue. I can scroll unstopped till I'm redirected to http://cowner.net/rweasy/-81168TUCJ/16627167/https://crhirt.blogspot.com/2019/01/how-to-use-system-spell-checker.html?rndad=3202093789-1576522192.

But maybe you can provide me with a bit more info.

Does this issue occur with a fresh profile? you can find the steps here: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Also, I've noticed that you are using an old version.
Can you please download Firefox Nightly from here: https://nightly.mozilla.org/ and retest the problem and see if the issue still occurs there as well? Or merely install the latest version of Firefox: https://www.mozilla.org/en-US/firefox/new/ and try again?

If after doing this you can still reproduce the bug, could you send me a screenshot or a video of the bug? That always helps a lot.

Thanks in advance, Flor.

Comment 3

[Graham Perrin]

Hi

Screen recording: above.

If I recall correctly the issue is reproducible with Firefox in safe mode.

The issue is also reproducible with Chromium 78.0.3904.108 (Official Build) (64-bit). Scrolling is interrupted by appearance of pop-up windows.

Firefox Nightly can not be used with FreeBSD-CURRENT, I might try on a Linux VM in the week.

Comment 4

[Florencia Di Ciocco, NI to vbalducci]

Graham,
If this issue is also reproducible with another browser (Chromium) I would have to say that this is not Firefox related. This suggest that there's a problem with the page. Wouldn't you agree?

Comment 5

[Graham Perrin]

From bug 253831 comment 384:

If you find pop-ups that get past our blocker and can reduce a testcase, please file new bugs for each specific cause.

It is, essentially, a pop-up that gets past blocking.

Comment 6

[Florencia Di Ciocco, NI to vbalducci]

Hi Graham,
Sorry to insist, but you haven't answered my question. If this issue is also reproducible with another browser (Chromium) I would have to say that this is not Firefox related. This suggests that there's a problem with the page. Wouldn't you agree?

Comment 7

[Graham Perrin]

If not a defect, then can this be a request for enhancement?

If Chromium lacks what's required to handle this apparent evasion of blocking, then should Chromium be a benchmark? With respect: I argue that Firefox should be better.

Invitation to comment: https://discourse.mozilla.org/t/new-generation-pop-up-blocker/36256/8?u=grahamperrin

Comment 8

[jscher2000]

On mine, the page shows an ad overlay in the page. When I dismiss the overlay by clicking the close button, popup windows are opened. Since sites are allowed to use window.open() in response to click events, this is not blocked by the popup blocker. (It appears some windows opened later in the script are being blocked, but I didn't investigate the difference.)

Guess: you have an extension that remove overlays that is triggering the popups by simulating a click.

Comment 9

[Graham Perrin]

Thanks,

(In reply to jscher2000 from comment #8)

Using the scroll bar, alone, is enough to trigger unwanted pop-ups.

A brief test with the keyboard alone does not trigger the pop-ups when scrolling.

Guess: you have an extension that remove overlays that is triggering the popups by simulating a click.

Re: bug 1603200 comment 3 above:

If I recall correctly the issue is reproducible with Firefox in safe mode.

Confirmed: reproducible in safe mode. Not involving an extension.

Comment 10

[jscher2000]

I see, I was using trackpad gestures for scrolling. This is a

Firefox allows popups on mouseup (see the dom.popup_allowed_events preference).

The page attaches an event handler to mouseup in the svw.js script:

document.onmouseup = openStuff;

For some reason, Firefox 71 sends the mouseup event to the document for scroll bar clicks (it does not send the click event). Why??

Testing in Nightly with the following in a less annoying page -- open the Web Console, execute this, and keep it open --

document.onmouseup = function(){console.log('mouseup event fired')};

-- I observe the counter rising as I click the scroll bar.

I also see it in Firefox 52 ESR so it doesn't appear to be a new behavior, but it probably should be modified so scrollbar clicks do not generate mouseup events in content.

Comment 11

[jscher2000]

Related:

• bug 1352332 - mousedown/mouseup events bubble when clicking on the scrollbar on Linux (P2)

Comment 12

[Florencia Di Ciocco, NI to vbalducci]

Hi,

So I've set this as an enhancement and I've chosen a component for this bug in hope that someone with more expertise may look at it. We'll await their answer.

Regards, Flor.

Comment 13

[Andrew Sutherland [:asuth] (he/him)]

needinfo-ing :johannh as the assignee on bug 1524619 for further triage/evaluation.

Comment 14

[Johann Hofmann [:johannh]]

Seems like this is just a dupe of bug 1352332, everything else looks expected here. Yes, it can be annoying to get a new popup on every click, but those are the rules right now. We might revisit them if this becomes a more prevalent annoyance (and if there's a viable alternative).