Closed Bug 1603358 Opened 1 year ago Closed 8 months ago

Enable Eager evaluation in all channels

Categories

(DevTools :: Console, task, P2)

task

Tracking

(firefox75 verified, firefox76 verified)

VERIFIED FIXED
Firefox 76
Tracking Status
firefox75 --- verified
firefox76 --- verified

People

(Reporter: Honza, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Assuming that Eager evaluation has been enabled in Nightly and passed QA testing, we can enable it in all channels and let it ride the trains.

The pref is: devtools.webconsole.input.eagerEvaluation

Honza

Priority: P3 → P2
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af76a7b08095
Enable Eager evaluation in all channels. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

[Tracking Requested - why for this release]: Once QA gives the green light, we would like to enable instant eval on release for 75.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/92f104deb441
Port bug 1603358 - Enable Eager evaluation in all channels. r=Paenglab
Regressions: 1623349
Regressions: 1623363

Comment on attachment 9133804 [details]
Bug 1603358 - Enable Eager evaluation in all channels. r=Honza.

Beta/Release Uplift Approval Request

  • User impact if declined: Missing feature. Preliminary QA status is green, so we should enable this for release to avoid late uplifts.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The feature was already enabled in DevEdition. This only uplifts the default-on flag for 75 beta/release.
  • String changes made/needed:
Attachment #9133804 - Flags: approval-mozilla-beta?

note that we should probably uplift Bug 1623363 before this one, otherwise we'll get test failures on beta.

Comment on attachment 9133804 [details]
Bug 1603358 - Enable Eager evaluation in all channels. r=Honza.

approved for 75.0b7

Attachment #9133804 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Janet, per comment 1, could we plan this in for an upcoming sprint?

Flags: needinfo?(jswisher)
Flags: qe-verify+

Verified with 75.0b7, 76.0a1 (2020-03-22) on Windows 10, macOS 10.15, Ubuntu 19.04.

Status: RESOLVED → VERIFIED

:Harald, I've already documented it, with a note that it's in Nightly (feedback welcome!). I would just need to update the note when it gets to Beta, and remove it upon Release.

Thank you Janet, sorry I missed that. I updated the keyword.

Flags: needinfo?(jswisher)
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.