1603358 - Enable Eager evaluation in all channels

Status: VERIFIED FIXED

(DevTools :: Console, task, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assuming that Eager evaluation has been enabled in Nightly and passed QA testing, we can enable it in all channels and let it ride the trains.

The pref is: devtools.webconsole.input.eagerEvaluation

Honza

Comment 1

[:Harald Kirschner :digitarald]

Should be documented in https://developer.mozilla.org/en-US/docs/Tools/Web_Console/The_command_line_interpreter

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1603358 - Enable Eager evaluation in all channels. r=Honza.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af76a7b08095
Enable Eager evaluation in all channels. r=Honza.

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/af76a7b08095

Comment 5

[:Harald Kirschner :digitarald]

[Tracking Requested - why for this release]: Once QA gives the green light, we would like to enable instant eval on release for 75.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/92f104deb441
Port bug 1603358 - Enable Eager evaluation in all channels. r=Paenglab

Comment 7

[:Harald Kirschner :digitarald]

Comment on attachment 9133804 [details]
Bug 1603358 - Enable Eager evaluation in all channels. r=Honza.

Beta/Release Uplift Approval Request

• User impact if declined: Missing feature. Preliminary QA status is green, so we should enable this for release to avoid late uplifts.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature was already enabled in DevEdition. This only uplifts the default-on flag for 75 beta/release.
• String changes made/needed:

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

note that we should probably uplift Bug 1623363 before this one, otherwise we'll get test failures on beta.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9133804 [details]
Bug 1603358 - Enable Eager evaluation in all channels. r=Honza.

approved for 75.0b7

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c20ad7990dc7

Comment 11

[:Harald Kirschner :digitarald]

Janet, per comment 1, could we plan this in for an upcoming sprint?

Comment 12

[Cristian Fogel [:cfogel]]

Verified with 75.0b7, 76.0a1 (2020-03-22) on Windows 10, macOS 10.15, Ubuntu 19.04.

Comment 13

[Janet Swisher]

:Harald, I've already documented it, with a note that it's in Nightly (feedback welcome!). I would just need to update the note when it gets to Beta, and remove it upon Release.

Comment 14

[:Harald Kirschner :digitarald]

Thank you Janet, sorry I missed that. I updated the keyword.