1603389 - "Show Content Messages" checkbox is reinitialized in the Omniscient Browser Toolbox after every restart

Status: RESOLVED FIXED

(DevTools :: Console, task, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open OBT, open console
• in the Console cog options, disable "Show Content Messages"
• close the OBT
• open OBT, open console

Expected Result: The setting should be persisted, "Show Content Messages" should be disabled
Actual Result: The setting is enabled again.

Note: this only applies to this setting. Timestamp and grouping options are correctly persisted across restarts.

Comment 1

[Julian Descottes [:jdescottes]]

Probably from this code that initializes the state of the console

showContentMessages: webConsoleUI.isBrowserConsole
        ? getBoolPref(PREFS.UI.CONTENT_MESSAGES)
        : true,

Comment 2

[Julian Descottes [:jdescottes]]

To be clear this should be updated to check webConsoleUI.isBrowserConsole || isBrowserToolbox (the catch is that we don't have a good isBrowserToolbox helper available I think)

Comment 3

[Julian Descottes [:jdescottes]]

Actually the console has webConsoleUI.isBrowserToolboxConsole which should be perfect here!

Comment 4

[Julian Descottes [:jdescottes]]

Nicolas, what do you think should be the default behavior of the Browser Toolbox Console? Should it show content messages by default or not?
Today, with the current code, the setting is always true on startup. If we change it to have the same logic as the Browser Console, then by default content messages will be hidden.

We can either:

• keep it disabled by default and update browser_toolbox_console_new_process.js to set the pref in the BT profile
• update the default value of devtools.browserconsole.contentMessages to be true (will then change the default behavior of the Browser Console)
• default it to true only for the Browser Toolbox Console (would be consistent with the current situation, but might be hard to justify)

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1603389 - Read content-process messages setting from prefs for BrowserToolbox Console

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1603389 - Read content messages setting from prefs for BrowserToolbox Console, and default to true for Browser Toolbox

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

I'd say let's keep it disabled to match the Browser Console logic.

Comment 8

[Julian Descottes [:jdescottes]]

sounds good, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45777f13e11a
Read content-process messages setting from prefs for BrowserToolbox Console r=nchevobbe

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/45777f13e11a