1603451 - browser-chrome test name not logged

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

Because we override add_task() in bc tests, the test name (function name) of the underlying test is lost:

INFO - Entering test bound 
INFO - TEST-PASS | remote/test/browser/browser_agent.js | remote-listening observer not notified - 
INFO - TEST-PASS | remote/test/browser/browser_agent.js | expected default port 49405, but got 49405 - 
INFO - Leaving test bound 

This is logged in browser-test.js:1060:

            this.SimpleTest.info("Entering test " + task.name);

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Nothing on bug 1589625 actually changed that behavior. It only refactored the code. The custom add_task implementation was already present before. So why do you think it has been caused by bug 1589625? Did you test that? I feel this problem exists since bug 1537768.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1603451: remote: document add_task()

The documentation for the overridden add_task() is quite poor.
Document it as to not confuse new developers why it is behaving
differently to the default bc add_task().

DONTBUILD

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1603451: remote: preserve test name from original task

The browser-chrome test name is derived from the function name.
The function name of the original task is lost when wrapped inside
the add_task() override in remote/test/browser/head.js.

This fixes the problem by rewriting the taskFn name on the new wrapper.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b207b360a5d
remote: document add_task() r=remote-protocol-reviewers,maja_zf,whimboo
https://hg.mozilla.org/integration/autoland/rev/f61815665e1f
remote: preserve test name from original task r=remote-protocol-reviewers,maja_zf,whimboo

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7b207b360a5d
https://hg.mozilla.org/mozilla-central/rev/f61815665e1f