1603496 - Tidy up reference type type checks

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Lars T Hansen [:lth]]

The code that checks that a given JS value that flows into wasm has the right type, or boxes the value in the case of an anyref, is fairly elaborate and is repeated several times; this is error-prone (indeed the nullref patch had an error that I discovered while working on the exnref patch). So abstract the test out and simplify the clients.

While we're in here, generalize some code that assumes that the only reference types are anyref and funcref.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1603496 - abstract reference-type checking on JS values. r=rhunt

Lift the code that checks JS values against reference types (and boxes anyref)
from all the places where it is repeated into a common function.

Clean up some code that assumes that the only reference types are anyref
and funcref.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f23128d93320
abstract reference-type checking on JS values.  r=rhunt

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f23128d93320