1603603 - Keep the perf-reftest-singletons in PGO in sync

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[(Away)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1596172#c6

Comment 1

[(Away)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1596172#c6 wasn't quite right (I was mixing up talos and raptor). The processing of the reftest_singletons manifest is baked into the talos machinery and not easily separable. I don't think the benefit is worth the time cost, so I'm going to throw up my hands and go with the suggestion of warning comments.

Comment 2

[(Away)]

Attachment: Add warning comments about keeping reftest_singletons.manifest in sync with PGO

While I'm here, I sorted the manifest, in order to match the sorted PGO list, so that it's easier to see when there's a discrepancy.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f13dacdf2f76
Add warning comments about keeping reftest_singletons.manifest in sync with PGO r=bzbarsky

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f13dacdf2f76

Comment 5

[Florin Strugariu [:Bebe]]

== Change summary for alert #24622 (as of Wed, 08 Jan 2020 13:10:11 GMT) ==

Improvements:

26% perf_reftest_singletons nth-index-2.html windows10-64-shippable-qr opt e10s stylo 4.43 -> 3.26
23% perf_reftest_singletons nth-index-2.html windows10-64-shippable opt e10s stylo 4.19 -> 3.21
23% perf_reftest_singletons nth-index-2.html linux64-shippable-qr opt e10s stylo 4.10 -> 3.16
22% perf_reftest_singletons nth-index-1.html windows10-64-shippable opt e10s stylo 4.07 -> 3.16
21% perf_reftest_singletons nth-index-1.html windows10-64-shippable-qr opt e10s stylo 4.18 -> 3.32
18% perf_reftest_singletons nth-index-2.html windows7-32-shippable opt e10s stylo 3.11 -> 2.56
16% perf_reftest_singletons nth-index-1.html windows7-32-shippable opt e10s stylo 2.86 -> 2.40
14% perf_reftest_singletons nth-index-1.html macosx1014-64-shippable opt e10s stylo 3.87 -> 3.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24622