1603629 - dominant-baseline hanging is inconsistent with other UAs

Status: RESOLVED FIXED

(Core :: SVG, defect, P5)

Description

[Karl Dubost💡 :karlcow]

+++ This bug was initially created as a clone of Bug #1403440 +++

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170925150345

dominant-baseline is broken with the value hanging:
https://webcompat.com/issues/19203#issuecomment-427004874

It's visible in https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/alignment-baseline#Example

Comment 1

[Robert Longson [:longsonr]]

I'm confused now, I thought there was an issue with that value in dominant-baseline. alignment-baseline is simply not supported at all.

Comment 2

[Robert Longson [:longsonr]]

Attachment: Bug 1603629 - fix dominant-baseline hanging and mathematical

Comment 3

[Robert Longson [:longsonr]]

https://github.com/chromium/chromium/blob/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/svg_text_layout_engine_baseline.cc#L141

To be equivalent we'd want mAscent - X

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2c4d300dc023036800749c5d9bdf6987551f872

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90039665bde4
fix dominant-baseline hanging and mathematical r=jfkthame

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/90039665bde4