1603634 - [mozharness] fix tests for python3

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, task)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

A lot of the issues when mozharness tests are run in python3, are the tests themselves.

For example, in test_base_config.py, the method _get_python_config() calls execfile, which is no longer supported in python3.

The only work required in this case is to wrap this in a if six.PY2 conditional and implement python2/3 cases.

This bug is to document the ongoing work to fix the tests themselves. Work requiring changes to the actual mozharness code should go under its own bugs that block the parent bug 1532427.

Comment 1

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1603634 - replace execfile syntax with python2/3 compatible call in test_base_config.py

Comment 2

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1603634 - wrap dictionary.keys() call with list() to ensure sortability

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b75773bd695
wrap dictionary.keys() call with list() to ensure sortability r=aki

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd8323891d68
replace execfile syntax with python2/3 compatible call in test_base_config.py r=aki

Comment 5

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1603634 - change to integer division operator for both python versions

Comment 6

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1603634 - replace file() call with open() in test_base_python.py

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8b75773bd695
https://hg.mozilla.org/mozilla-central/rev/cd8323891d68

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0080453fdf41
change to integer division operator for both python versions r=aki

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc8ac1530aba
replace file() call with open() in test_base_python.py r=aki

Comment 10

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1603634 - ensure iterated value is a list and only perform decode if value supports such action in mozharness/base/log.py

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0080453fdf41
https://hg.mozilla.org/mozilla-central/rev/bc8ac1530aba

Comment 12

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1603634 - check if line is a decodable type

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bbca9c01ba3
check if line is a decodable type r=aki,marco

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2b49a6d061b
ensure iterated value is a list and only perform decode if value supports such action in mozharness/base/log.py r=aki,marco

Comment 15

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3bbca9c01ba3

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a2b49a6d061b

Comment 17

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1603634 - use python3.6 to run mozharness tests in python3

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e9830f213c8
use python3.6 to run mozharness tests in python3 r=jmaher

Comment 19

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7e9830f213c8