Closed Bug 1603635 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 20761 - Enable the CSS image-orientation always

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20761 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20761
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

Enable the CSS image-orientation always

The spec has been updated to something we can commit to.
Intent to Ship has been approved.

So implement the CSS image-orientation property for all
images (content and style) and change the valid values
to "from-image" or "none". Update tests accordingly.

This does not remove the flag in case we need to turn it
off.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/image-orientation%7Csort:date/blink-dev/jPgnRoivOis/X1E6SuOoAwAJ

Bug: 158753
Change-Id: Ib50d263b01f7cf6b2d17174138fd223a8105da8e
Reviewed-on: https://chromium-review.googlesource.com/1846319
WPT-Export-Revision: 4d845c03f09c6685a05a2c5ceadfac5a2003b894

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 5
FAIL: 3

Chrome

OK : 1
PASS: 6
FAIL: 2

Safari

OK : 1
PASS: 6
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL

New Tests That Don't Pass

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL (Chrome: PASS, Safari: PASS)
Property image-orientation has initial value from-image: FAIL (Chrome: FAIL, Safari: FAIL)
Property image-orientation inherits: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 5
FAIL: 3

Chrome

OK : 1
PASS: 6
FAIL: 2

Safari

OK : 1
PASS: 6
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL

New Tests That Don't Pass

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL (Chrome: PASS, Safari: PASS)
Property image-orientation has initial value from-image: FAIL (Chrome: FAIL, Safari: FAIL)
Property image-orientation inherits: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 5
FAIL: 3

Chrome

OK : 1
PASS: 6
FAIL: 2

Safari

OK : 1
PASS: 6
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL

New Tests That Don't Pass

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL (Chrome: PASS, Safari: PASS)
Property image-orientation has initial value from-image: FAIL (Chrome: FAIL, Safari: FAIL)
Property image-orientation inherits: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07461a4d0a72 [wpt PR 20761] - Enable the CSS image-orientation always, a=testonly https://hg.mozilla.org/integration/autoland/rev/f6f0181fd4fb [wpt PR 20761] - Update wpt metadata, a=testonly

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 5
FAIL: 3

Chrome

OK : 1
PASS: 6
FAIL: 2

Safari

OK : 1
PASS: 6
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL

New Tests That Don't Pass

/css/css-images/inheritance.html
Property image-rendering inherits: FAIL (Chrome: PASS, Safari: PASS)
Property image-orientation has initial value from-image: FAIL (Chrome: FAIL, Safari: FAIL)
Property image-orientation inherits: FAIL (Chrome: FAIL, Safari: FAIL)

Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/07461a4d0a72
https://hg.mozilla.org/mozilla-central/rev/f6f0181fd4fb

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.