1603636 - Find toolbar's "Match Diacritics" Alt+D hotkey conflicts with the address bar

Status: VERIFIED FIXED

(Core :: Find Backend, defect)

Description

[zlice]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

in 73 nightly, doing a "ctrl+F" to find on a page now has a "Match Diacritics" hotkey of "alt+D" which breaks the addressbar hotkey of "alt+D"
this should be changed (to "alt+i" which seems to have no hotkey assigned to it?)

ctrl+F
find something (focus stays on findbar)
alt+D

Actual results:

toggles "Match Diacritics"

Expected results:

go to URL bar

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0
20191212215040

Alt+D to focus the address bar has been around for ages. It should still work even when the find toolbar is open.

Comment 2

[Alex Henrie]

Interesting. I was actually unaware of Alt+D because I always use Ctrl+L instead.

Comment 3

[Alex Henrie]

Attachment: Bug 1603636 - Change "Match Diacritics" shortcut to Alt+I.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5aa3fbff84f5
Change "Match Diacritics" shortcut to Alt+I. r=fluent-reviewers,mikedeboer,flod

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5aa3fbff84f5

Comment 6

[zlice]

thanks all

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue using Firefox 73.0a1 (20191212215040) on Windows 10x64.
The issue is verified fixed with 73.0b8 (20200122012721) on Windows 10x64, macOS 10.15 and Ubuntu 18.04. Pressing ALT+D after CTR+F focuses the address bar (Windows and Ubuntu) and "Match Diacritics" is selected with ALT+I as expected.

Comment 8

[Weng Xuetian]

This is not fixed at least for Chinese language pack for Firefox 74.

The Match Diacritics under Simplified Chinese locale is still using "d" as accelerator. (搜索变音文字(_D))

Comment 9

[Weng Xuetian]

Attachment: Search bar under chinese language.

Comment 10

[Alex Henrie]

I made a request at https://pontoon.mozilla.org/zh-CN/firefox/toolkit/toolkit/main-window/findbar.ftl/?string=206128 but I don't have any control over whether it will be accepted or when.

Comment 11

[YF (Yang)]

I see this change has been approved.