1603673 - enable dom.manifest.enabled for GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Marcos Caceres [:marcosc]]

GeckoView supports processing web manifests, so let's enable dom.manifest.enabled for GeckoView (and Fenix).

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: enable dom.manifest.enabled for GeckoView

sets dom.manifest.enabled to true for GeckoView.

Discussed with Bz about enabling more generally in Gecko,
but we decided against it. This should be enabled on a
per-product basis, if a product actually supports
a web manifest in a meaningful way.

Comment 2

[Marcos Caceres [:marcosc]]

Attachment: Signal that we support web manifest processing in Fenix

When enabled, link.relList.supports("manifest") will return true.

Comment 3

[Marcos Caceres [:marcosc]]

Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=baa6c26ede1fca22ac2c9dad87d089fc48632781

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/061d47c2c5c7
Signal that we support web manifest processing in Fenix r=snorp

Comment 5

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 061d47c2c5c7 (Bug 1603673) for mozlint failure in /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=289294028

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289294028&repo=autoland&lineNumber=1118

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/714d07041daf
Backed out changeset 061d47c2c5c7 for mozlint failure in /builds/worker/checkouts/gecko/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa5ee85e20a5
Signal that we support web manifest processing in Fenix r=snorp

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out changeset fa5ee85e20a5 (Bug 1603673) for causing lint failure in GeckoRuntimeSettings.java CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=289305050&resultStatus=testfailed%2Cbusted%2Cexception&revision=fa5ee85e20a511227205a99d4875fcf17b08b3a6

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289305050&repo=autoland&lineNumber=1096

Backout: https://hg.mozilla.org/integration/autoland/rev/eae597c03f1f0b4da80dc5e282543ffe8c1e6c63

Comment 9

[Noemi Erli[:noemi_erli]]

Also, some of the initial failures for which this bug was backed out before can be seen again:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289307367&repo=autoland&lineNumber=70722
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289307372&repo=autoland&lineNumber=1416
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289310078&repo=autoland&lineNumber=12629

Comment 10

[Marcos Caceres [:marcosc]]

Ah, excellent! thanks Noemi. Will fix those too.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c1dd534e937
Signal that we support web manifest processing in Fenix r=snorp,agi,ladybenko

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for geckoview failures on webAppManifestPref.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9e8d5431c4121a4bd70d440c98b50444aee60dd9
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290718910&repo=autoland&lineNumber=2296

Comment 13

[Marcos Caceres [:marcosc]]

:fluffyemily, I'm really sorry, but I keep hitting issues with the test suite as I don't actually know any Kotlin or how the testing framework works :( The DOM side of this is all working fine, but I really need someone from the Android team to quickly check the Kotlin exception for me (I left a stack-trace on Phabricator)... everything is 99.999% done (and r+'ed by Agi), so it should take someone on the Android side for a few mins to figure out what I'm missing... no doubt a silly one-line typo 🙏

Comment 14

[Eugen Sawin [:esawin]]

(In reply to Marcos Caceres [:marcosc] from comment #13)

:fluffyemily, I'm really sorry, but I keep hitting issues with the test suite as I don't actually know any Kotlin or how the testing framework works :( The DOM side of this is all working fine, but I really need someone from the Android team to quickly check the Kotlin exception for me (I left a stack-trace on Phabricator)... everything is 99.999% done (and r+'ed by Agi), so it should take someone on the Android side for a few mins to figure out what I'm missing... no doubt a silly one-line typo 🙏

The test passes fine here, the issue is with the way you invoke the test, use mach geckoview-junit org.mozilla.geckoview.test.ContentDelegateTest instead.

Comment 15

[Marcos Caceres [:marcosc]]

Oh, lol, ok 🙈 I was doing:

./mach geckoview-junit mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ContentDelegateTest.kt

Will send try to merge it again. Thanks again Esawin! you are a total lifesaver!

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27b9929438f8
Signal that we support web manifest processing in Fenix r=snorp,agi,ladybenko

Comment 17

[Razvan Maries]

Backed out for perma failures on browser_ssb_manifest_scope.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=291558288&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-7%2Cm%28bc7%29&revision=27b9929438f8fc609c778a703f954b1bc36fc532

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291558288&repo=autoland&lineNumber=16975

Backout: https://hg.mozilla.org/integration/autoland/rev/21b793f34258a763b900fce17b9b97678c2198fa

Comment 18

[Marcos Caceres [:marcosc]]

thanks, fixed! Will send again.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c99ced25f6b
Signal that we support web manifest processing in Fenix r=snorp,agi,ladybenko

Comment 20

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4c99ced25f6b