Closed Bug 1603690 Opened 4 months ago Closed 4 months ago

ScriptLoader.cpp: redundant return statement at the end of a function with a void return type

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: Sylvestre, Assigned: atiwarixs, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/dom/script/ScriptLoader.cpp#2377

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Summary: redundant return statement at the end of a function with a void return type → ScriptLoader.cpp: redundant return statement at the end of a function with a void return type
Attachment #9115729 - Attachment description: Bug 1603690 - Remove a redundant return statement. r?Ehsan → Bug 1603690 - Remove a redundant return statement and removed empty lines. r?Ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52572121c7ff
Remove a redundant return statement and removed empty lines. r=Ehsan
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.