Closed
Bug 1603690
Opened 4 years ago
Closed 4 years ago
ScriptLoader.cpp: redundant return statement at the end of a function with a void return type
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox73 fixed)
RESOLVED
FIXED
mozilla73
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: atiwarixs, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
return;
at the end of a void function is useless
https://searchfox.org/mozilla-central/source/dom/script/ScriptLoader.cpp#2377
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Reporter | ||
Updated•4 years ago
|
Summary: redundant return statement at the end of a function with a void return type → ScriptLoader.cpp: redundant return statement at the end of a function with a void return type
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Attachment #9115729 -
Attachment description: Bug 1603690 - Remove a redundant return statement. r?Ehsan → Bug 1603690 - Remove a redundant return statement and removed empty lines. r?Ehsan
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52572121c7ff Remove a redundant return statement and removed empty lines. r=Ehsan
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•