1603701 - Enable test262 WeakRef tests

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Now that we've landed WeakRef support in the shell let's turn on the relevant test262 tests and make sure they pass.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 1: Enable test262 WeakRef tests on infra.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 2: update WeakRef tests in test262.

Update WeakRefs after running ./test262-update.py

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 3: fix WeakRef failure.

To fix the failures in:
js/src/tests/test262/built-ins/WeakRef/length.js
test262/built-ins/WeakRef/prototype/deref/length.js

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 4: define clearKeptObjects in test262-host.js

clearKeptObjects will be called in asyncGCDeref.

This is needed for the following test:
test262/built-ins/WeakRef/prototype/deref/gc-cleanup-not-prevented-with-wr-deref.js

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 5 : Check if records have been cleared.

To fix the failure in
test262/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-prevented-with-unregister.js

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 6: test262 update

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 1: Enable test262 WeakRef tests on infra.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 2: update WeakRef tests in test262.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 3: fix WeakRef failure.

To fix the failures in:
js/src/tests/test262/built-ins/WeakRef/length.js
test262/built-ins/WeakRef/prototype/deref/length.js

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 4: define clearKeptObjects in test262-host.js.

clearKeptObjects will be called in asyncGCDeref.

This is needed for the following test:
test262/built-ins/WeakRef/prototype/deref/gc-cleanup-not-prevented-with-wr-deref.js

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1603701 - Part 5 : Check if records have been cleared.

To fix the failure in
test262/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-prevented-with-unregister.js

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I accidently create the new commits, so I obsolete the older ones.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16dadfc1d2ef
Part 1: Enable test262 WeakRef tests on infra. r=jonco
https://hg.mozilla.org/integration/autoland/rev/0bfe04276fe3
Part 2: update WeakRef tests in test262. r=jonco
https://hg.mozilla.org/integration/autoland/rev/7eaae56528c4
Part 3: fix WeakRef failure. r=jonco
https://hg.mozilla.org/integration/autoland/rev/912fed7c5710
Part 4: define clearKeptObjects in test262-host.js. r=jonco

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/16dadfc1d2ef
https://hg.mozilla.org/mozilla-central/rev/0bfe04276fe3
https://hg.mozilla.org/mozilla-central/rev/7eaae56528c4
https://hg.mozilla.org/mozilla-central/rev/912fed7c5710