Closed Bug 1603701 Opened 4 months ago Closed 3 months ago

Enable test262 WeakRef tests

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: jonco, Assigned: allstars.chh)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 7 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Now that we've landed WeakRef support in the shell let's turn on the relevant test262 tests and make sure they pass.

Assignee: nobody → allstars.chh
Priority: -- → P1

Update WeakRefs after running ./test262-update.py

To fix the failures in:
js/src/tests/test262/built-ins/WeakRef/length.js
test262/built-ins/WeakRef/prototype/deref/length.js

clearKeptObjects will be called in asyncGCDeref.

This is needed for the following test:
test262/built-ins/WeakRef/prototype/deref/gc-cleanup-not-prevented-with-wr-deref.js

To fix the failure in
test262/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-prevented-with-unregister.js

To fix the failures in:
js/src/tests/test262/built-ins/WeakRef/length.js
test262/built-ins/WeakRef/prototype/deref/length.js

clearKeptObjects will be called in asyncGCDeref.

This is needed for the following test:
test262/built-ins/WeakRef/prototype/deref/gc-cleanup-not-prevented-with-wr-deref.js

To fix the failure in
test262/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-prevented-with-unregister.js

Attachment #9119401 - Attachment is obsolete: true
Attachment #9119402 - Attachment is obsolete: true
Attachment #9119403 - Attachment is obsolete: true
Attachment #9119404 - Attachment is obsolete: true
Attachment #9119405 - Attachment is obsolete: true
Attachment #9119406 - Attachment is obsolete: true

I accidently create the new commits, so I obsolete the older ones.

Attachment #9119701 - Attachment description: Bug 1603701 - Part2: update WeakRef tests in test262. → Bug 1603701 - Part 2: update WeakRef tests in test262.
Attachment #9119704 - Attachment is obsolete: true
Pushed by allstars.chh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/16dadfc1d2ef
Part 1: Enable test262 WeakRef tests on infra. r=jonco
https://hg.mozilla.org/integration/autoland/rev/0bfe04276fe3
Part 2: update WeakRef tests in test262. r=jonco
https://hg.mozilla.org/integration/autoland/rev/7eaae56528c4
Part 3: fix WeakRef failure. r=jonco
https://hg.mozilla.org/integration/autoland/rev/912fed7c5710
Part 4: define clearKeptObjects in test262-host.js. r=jonco
You need to log in before you can comment on or make changes to this bug.