Closed Bug 1603871 Opened 1 year ago Closed 1 year ago

Minor nsDocumentViewer cleanup.

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

No description provided.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/080ffc0db292
Simplify some bits in nsDocumentViewer. r=smaug

Backed out for bustages on nsDocumentViewer.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/72dc29cbba410649bb27e9dfe4d9d3c8123557c0

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=080ffc0db29222fc42d88ddc27561029f8f00dd8&selectedJob=281139900

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281139850&repo=autoland&lineNumber=28916

[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - In file included from Unified_cpp_layout_base1.cpp:74:
[task 2019-12-13T23:24:54.048Z] 23:24:54 ERROR - /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp:163:3: error: bad implicit conversion constructor for 'nsDocViewerSelectionListener'
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - nsDocViewerSelectionListener(nsDocumentViewer* aDocViewer)
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - ^
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp:163:3: note: consider adding the explicit keyword to the constructor
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - nsDocViewerSelectionListener(nsDocumentViewer* aDocViewer)
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - ^
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - explicit
[task 2019-12-13T23:24:54.048Z] 23:24:54 ERROR - /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp:178:3: error: bad implicit conversion constructor for 'nsDocViewerFocusListener'
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - nsDocViewerFocusListener(nsDocumentViewer* aDocViewer)
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - ^
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp:178:3: note: consider adding the explicit keyword to the constructor
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - nsDocViewerFocusListener(nsDocumentViewer* aDocViewer)
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - ^
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - explicit
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - 2 errors generated.
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - /builds/worker/workspace/build/src/config/rules.mk:736: recipe for target 'Unified_cpp_layout_base1.o' failed
[task 2019-12-13T23:24:54.048Z] 23:24:54 ERROR - make[4]: *** [Unified_cpp_layout_base1.o] Error 1
[task 2019-12-13T23:24:54.048Z] 23:24:54 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/base'
[task 2019-12-13T23:24:54.051Z] 23:24:54 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'layout/base/target-objects' failed
[task 2019-12-13T23:24:54.051Z] 23:24:54 ERROR - make[3]: *** [layout/base/target-objects] Error 2
[task 2019-12-13T23:24:54.051Z] 23:24:54 INFO - make[3]: *** Waiting for unfinished jobs....

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b26040ef680
Simplify some bits in nsDocumentViewer. r=smaug
Flags: needinfo?(emilio)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Type: defect → enhancement
You need to log in before you can comment on or make changes to this bug.