1603930 - Perma remote/test/browser/browser_agent.js | Uncaught exception - [Exception... "Disabled by preference" nsresult: "0x80040111 ...] when Gecko 73 merges to Beta on 2020-01-06

Status: VERIFIED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Dorel Luca [:dluca]]

[Tracking Requested - why for this release]:

Central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=957cb1f27bd7daefa9e50ccb05da7e0a1bea0198&selectedJob=281184138

Failure log:
https://treeherder.mozilla.org/logviewer.html#?job_id=281184138&repo=try

NFO - TEST-START | remote/test/browser/browser_agent.js
[task 2019-12-14T12:43:05.895Z] 12:43:05     INFO - TEST-INFO | started process screentopng
[task 2019-12-14T12:43:06.586Z] 12:43:06     INFO - TEST-INFO | screentopng: exit 0
[task 2019-12-14T12:43:06.586Z] 12:43:06     INFO - Buffered messages logged at 12:43:05
[task 2019-12-14T12:43:06.586Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.586Z] 12:43:06     INFO - TEST-PASS | remote/test/browser/browser_agent.js | Agent is not listening - 
[task 2019-12-14T12:43:06.587Z] 12:43:06     INFO - TEST-PASS | remote/test/browser/browser_agent.js | Agent is listening - 
[task 2019-12-14T12:43:06.587Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.588Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.588Z] 12:43:06     INFO - Buffered messages finished
[task 2019-12-14T12:43:06.588Z] 12:43:06     INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/browser_agent.js | Uncaught exception - [Exception... "Disabled by preference"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://remote/content/RemoteAgent.jsm :: listen :: line 36"  data: no]
[task 2019-12-14T12:43:06.588Z] 12:43:06     INFO - Stack trace:
[task 2019-12-14T12:43:06.588Z] 12:43:06     INFO - listen@chrome://remote/content/RemoteAgent.jsm:36:24
[task 2019-12-14T12:43:06.589Z] 12:43:06     INFO - listen@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:41:21
[task 2019-12-14T12:43:06.589Z] 12:43:06     INFO - add_agent_task/<@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:17:13
[task 2019-12-14T12:43:06.589Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.590Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.590Z] 12:43:06     INFO - TEST-PASS | remote/test/browser/browser_agent.js | undefined assertion name - 
[task 2019-12-14T12:43:06.590Z] 12:43:06     INFO - TEST-PASS | remote/test/browser/browser_agent.js | undefined assertion name - 
[task 2019-12-14T12:43:06.590Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.590Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.590Z] 12:43:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-12-14T12:43:06.594Z] 12:43:06     INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/browser_agent.js | Uncaught exception - [Exception... "Disabled by preference"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://remote/content/RemoteAgent.jsm :: listen :: line 36"  data: no]
[task 2019-12-14T12:43:06.594Z] 12:43:06     INFO - Stack trace:
[task 2019-12-14T12:43:06.594Z] 12:43:06     INFO - listen@chrome://remote/content/RemoteAgent.jsm:36:24
[task 2019-12-14T12:43:06.594Z] 12:43:06     INFO - listenTakesString@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:63:21
[task 2019-12-14T12:43:06.594Z] 12:43:06     INFO - add_agent_task/<@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:17:13
[task 2019-12-14T12:43:06.594Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.594Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.595Z] 12:43:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-12-14T12:43:06.595Z] 12:43:06     INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/browser_agent.js | undefined assertion name - Got 2147746065, expected 2152398858
[task 2019-12-14T12:43:06.596Z] 12:43:06     INFO - Stack trace:
[task 2019-12-14T12:43:06.596Z] 12:43:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2019-12-14T12:43:06.597Z] 12:43:06     INFO - chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:listenNonURL:73
[task 2019-12-14T12:43:06.597Z] 12:43:06     INFO - chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:add_agent_task/<:17
[task 2019-12-14T12:43:06.598Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.600Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.600Z] 12:43:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-12-14T12:43:06.601Z] 12:43:06     INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/browser_agent.js | undefined assertion name - Got 2147746065, expected 2147942487
[task 2019-12-14T12:43:06.601Z] 12:43:06     INFO - Stack trace:
[task 2019-12-14T12:43:06.602Z] 12:43:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2019-12-14T12:43:06.602Z] 12:43:06     INFO - chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:listenRestrictedToLoopbackDevice:82
[task 2019-12-14T12:43:06.606Z] 12:43:06     INFO - chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:add_agent_task/<:17
[task 2019-12-14T12:43:06.609Z] 12:43:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-12-14T12:43:06.618Z] 12:43:06     INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/browser_agent.js | undefined assertion name - Got Disabled by preference, expected Restricted to loopback devices
[task 2019-12-14T12:43:06.618Z] 12:43:06     INFO - Stack trace:
[task 2019-12-14T12:43:06.618Z] 12:43:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2019-12-14T12:43:06.619Z] 12:43:06     INFO - chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:listenRestrictedToLoopbackDevice:83
[task 2019-12-14T12:43:06.619Z] 12:43:06     INFO - chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:add_agent_task/<:17
[task 2019-12-14T12:43:06.620Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.620Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.621Z] 12:43:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-12-14T12:43:06.621Z] 12:43:06     INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/browser_agent.js | Uncaught exception - [Exception... "Disabled by preference"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://remote/content/RemoteAgent.jsm :: listen :: line 36"  data: no]
[task 2019-12-14T12:43:06.622Z] 12:43:06     INFO - Stack trace:
[task 2019-12-14T12:43:06.622Z] 12:43:06     INFO - listen@chrome://remote/content/RemoteAgent.jsm:36:24
[task 2019-12-14T12:43:06.623Z] 12:43:06     INFO - listenNonLoopbackDevice@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:89:21
[task 2019-12-14T12:43:06.624Z] 12:43:06     INFO - add_agent_task/<@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:17:13
[task 2019-12-14T12:43:06.625Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.626Z] 12:43:06     INFO - Entering test bound 
[task 2019-12-14T12:43:06.626Z] 12:43:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-12-14T12:43:06.628Z] 12:43:06     INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/browser_agent.js | Uncaught exception - [Exception... "Disabled by preference"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://remote/content/RemoteAgent.jsm :: listen :: line 36"  data: no]
[task 2019-12-14T12:43:06.628Z] 12:43:06     INFO - Stack trace:
[task 2019-12-14T12:43:06.629Z] 12:43:06     INFO - listen@chrome://remote/content/RemoteAgent.jsm:36:24
[task 2019-12-14T12:43:06.630Z] 12:43:06     INFO - test_close@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:93:21
[task 2019-12-14T12:43:06.646Z] 12:43:06     INFO - add_agent_task/<@chrome://mochitests/content/browser/remote/test/browser/browser_agent.js:17:13
[task 2019-12-14T12:43:06.646Z] 12:43:06     INFO - Leaving test bound 
[task 2019-12-14T12:43:06.646Z] 12:43:06     INFO - GECKO(1123) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-12-14T12:43:06.647Z] 12:43:06     INFO - GECKO(1123) | MEMORY STAT heapAllocated not supported in this build configuration.
[task 2019-12-14T12:43:06.647Z] 12:43:06     INFO - GECKO(1123) | MEMORY STAT | vsize 20974851MB | residentFast 1083MB
[task 2019-12-14T12:43:06.647Z] 12:43:06     INFO - TEST-OK | remote/test/browser/browser_agent.js | took 329ms

This seems to be a regression of bug 1600330.

Andreas: Can you please take a look?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

The remote agent is only enabled for Nightly builds. So the tests should basically not run at all on Beta. Looks like we miss to conditionally skip those.

Comment 2

[Cosmin Sabou [:CosminS]]

Attachment: bug 1603930: remote: skip M(remote) tests on release_or_beta;

Comment 3

[Andreas Tolfsen ❲:ato❳]

The remote/test/browser/ bc test manifests are defined in remote/test/moz.build, which is included by remote/moz.build.

The remote/ directory is only included in the build when ENABLE_REMOTE_AGENT is true, which it is when --enable-cdp is used or these default conditions are met:
https://searchfox.org/mozilla-central/rev/6bceafe72cad5d5752667b4b6bd595d3a4047ca3/toolkit/moz.configure#927-958

And this is the entry conditional for including remote/moz.build:
https://searchfox.org/mozilla-central/rev/6bceafe72cad5d5752667b4b6bd595d3a4047ca3/toolkit/toolkit.mozbuild#164

As whimboo said, it’s not clear why these tests are run at all on beta because the manifests shouldn’t be defined. I can’t spot any obvious mistakes with the logic here…

Comment 4

[Andreas Tolfsen ❲:ato❳]

How can I change the release channel to test this locally in my mozconfig?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://wiki.mozilla.org/Sheriffing/How_To/Beta_simulations#TRUNK_AS_EARLY_BETA has information how to run beta simulations.

ENABLE_REMOTE_AGENT is set to 1 according to the build log. The documentation mentions --enable-cdp but the switch is --disabled-cdp.

Comment 6

[Andreas Tolfsen ❲:ato❳]

I missed the point that this is a regression from bug 1600330, which makes sense because it explicitly runs tests without setting remote.enabled.

We still need to figure out why that bc test is being included in the manifest, so setting a needinfo for myself to try out Aryx’ suggestion.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Andreas, would you mind prioritizing this work so we can finish it before we are all going to PTO? The merge will happen on January 6th so it would be unlikely to land a fix on that day.

Comment 8

[Andreas Tolfsen ❲:ato❳]

(In reply to Sebastian Hengst [:aryx] [limited availability until start of 2020] (needinfo on intermittent or backout) from comment #5)

https://wiki.mozilla.org/Sheriffing/How_To/Beta_simulations#TRUNK_AS_EARLY_BETA has information how to run beta simulations.

Hm, this does not actually mention how to do a beta simulation locally, which is what I need here.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Is running the command to generate the beta simulations with --no-push, committing the changes and building locally sufficient for your needs? If not, please needinfo Tom Prince.

Comment 10

[Nathan Froyd [:froydnj]]

I have nothing to add to Aryx's comment.

Comment 11

[Andreea Pavel [:apavel]]

Importing the patch makes the failures go away:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=2523642c00288fc0fdda63af3cad3f316d4ae565&searchStr=remote&selectedJob=282328071

Comment 12

[Intermittent Failures Robot]

1 failures in 4582 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1603930&startday=2019-12-16&endday=2019-12-22&tree=all

Comment 13

[Arthur Iakab [arthur_iakab]]

I can confirm that applying the patch the failures do not occur in today's central as beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=282393837&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a682470a44b50c2d613e562a615a59d0b060a72e&searchStr=mochitest

Comment 14

[Andreas Tolfsen ❲:ato❳]

(In reply to Sebastian Hengst [:aryx] [limited availability until start of 2020] (needinfo on intermittent or backout) from comment #9)

Is running the command to generate the beta simulations with --no-push, committing the changes and building locally sufficient for your needs? If not, please needinfo Tom Prince.

Mea culpa. I completely missed that option.

I’m now able to reproduce the problem.

Comment 15

[Andreas Tolfsen ❲:ato❳]

I can see that ENABLE_REMOTE_AGENT is set in various build output files:

mozilla-config.h:27:#define ENABLE_REMOTE_AGENT 1
config.status:109:    'ENABLE_REMOTE_AGENT': '1',
config.status:1107:    'ENABLE_REMOTE_AGENT': '1',
…
config/autoconf.mk:44:ENABLE_REMOTE_AGENT = 1
config.statusd/defines/ALLDEFINES:128:    "ENABLE_REMOTE_AGENT": "1",
…

Reversing “enable” and “disable” in toolkit/moz.configure appears to have a satisfactory effect:

diff --git a/toolkit/moz.configure b/toolkit/moz.configure
index a61116b0e77c..e2f0d07b65b5 100644
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -944,7 +944,7 @@ def remote_default(target, project, milestone):
     # TODO(ato): https://bugzil.la/1544393
     return project == 'browser' and milestone.is_nightly
 
-option('--disable-cdp', default=remote_default,
+option('--enable-cdp', default=remote_default,
        help='{Enable|Disable} remote agent')
 
 @depends('--disable-cdp')

With this change we see the expected result when trying to run the test on the beta simulation build:

% ./mach test --headless remote/test/browser/browser_agent.js
UNKNOWN TEST: remote/test/browser/browser_agent.js

This means that we’ve accidentally been building the remote agent component on all release branches since end of April. This is in itself not a huge problem because all it does is expose an extra non-functional flag in --help: using the remote agent was not possible because it is disabled by a preference.

The test in question is new and runs intentionally without setting the remote.enabled preference to catch exactly this kind of bug, so I’m really glad I spent some time writing it.

Comment 16

[Andreas Tolfsen ❲:ato❳]

For the record, I also confirmed that --remote-debugging-port is listed in --help on Firefox 71.0 stable.

Because the flag doesn’t cause any harm, I’m not inclined to jump through the extra hoops of backporting the patch to earlier release branches (although it would be trivial.)

Comment 17

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1603930: toolkit: fix remote agent build targets;

The remote agent component was meant to only be built on the
Nightly release channel, but 868b1bf043dc accidentally reversed
--enable-cdp and --reverse-cdp, not understanding that there's a
semantic difference in the build config parser for this.

This has had the undesired effect that the remote agent has been
built on all release channels since around 25th April of this year.
This in itself is not a huge concern because the feature is disabled
through the remote.enabled preference in modules/libpref/init/all.js,
except on Nightly.

This patch reverses s/disable/enable/ which causes ENABLE_REMOTE_AGENT
to be set only on the Nightly release channel, or when --enable-cdp
is explicitly used, thus achieving the original, intended effect.

We caught this when running the bc test
remote/test/browser/browser_agent.js as part of beta simulations
for Firefox 73. I wrote that test explicitly to test for this
eventuality, so I will consider it good enough for this change to
ship without additional tests.

Comment 18

[Andreas Tolfsen ❲:ato❳]

Beta simulation try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a765c023928cd69332f5232ef036d8e0ab9fff5

Regular try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6095366230eaa73c50be07fb664efcb8d80432d8

Comment 19

[Cosmin Sabou [:CosminS]]

Andreas, unfortunately some other remote failures have occurred: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a765c023928cd69332f5232ef036d8e0ab9fff5&searchStr=remote&selectedJob=283065663

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283065663&repo=try&lineNumber=1456

[task 2019-12-31T18:01:38.613Z] 18:01:38 INFO - Checking for xpcshell processes...
[task 2019-12-31T18:01:38.731Z] 18:01:38 ERROR - No tests were found for flavor 'browser' and the following manifest filters:
[task 2019-12-31T18:01:38.732Z] 18:01:38 ERROR - skip_if, run_if, fail_if, subsuite(name=remote), pathprefix(['remote/test/browser/browser.ini', 'remote/test/browser/emulation/browser.ini', 'remote/test/browser/input/browser.ini', 'remote/test/browser/io/browser.ini', 'remote/test/browser/network/browser.ini', 'remote/test/browser/page/browser.ini', 'remote/test/browser/runtime/browser.ini', 'remote/test/browser/security/browser.ini', 'remote/test/browser/target/browser.ini'])
[task 2019-12-31T18:01:38.734Z] 18:01:38 ERROR -
[task 2019-12-31T18:01:38.735Z] 18:01:38 ERROR - Make sure the test paths (if any) are spelt correctly and the corresponding
[task 2019-12-31T18:01:38.736Z] 18:01:38 ERROR - --flavor and --subsuite are being used. See mach mochitest --help for a
[task 2019-12-31T18:01:38.737Z] 18:01:38 ERROR - list of valid flavors.
[task 2019-12-31T18:01:38.738Z] 18:01:38 ERROR -
[task 2019-12-31T18:01:38.739Z] 18:01:38 INFO - SUITE-START | Running 0 tests
[task 2019-12-31T18:01:38.740Z] 18:01:38 INFO - TEST-INFO | checking window state
[task 2019-12-31T18:01:38.742Z] 18:01:38 INFO - Browser Chrome Test Summary
[task 2019-12-31T18:01:38.743Z] 18:01:38 INFO - Passed: 0
[task 2019-12-31T18:01:38.745Z] 18:01:38 INFO - Failed: 0
[task 2019-12-31T18:01:38.747Z] 18:01:38 INFO - Todo: 0
[task 2019-12-31T18:01:38.749Z] 18:01:38 INFO - Mode: e10s
[task 2019-12-31T18:01:38.751Z] 18:01:38 INFO - *** End BrowserChrome Test Results ***
[task 2019-12-31T18:01:38.752Z] 18:01:38 INFO - Buffered messages finished
[task 2019-12-31T18:01:38.753Z] 18:01:38 INFO - SUITE-END | took 0s
[task 2019-12-31T18:01:38.813Z] 18:01:38 ERROR - Return code: 1
[task 2019-12-31T18:01:38.814Z] 18:01:38 ERROR - No checks run.
[task 2019-12-31T18:01:38.815Z] 18:01:38 INFO - TinderboxPrint: mochitest-mochitest-remote<br/><em class="testfail">T-FAIL</em>
[task 2019-12-31T18:01:38.816Z] 18:01:38 ERROR - # TBPL FAILURE #
[task 2019-12-31T18:01:38.816Z] 18:01:38 WARNING - setting return code to 2
[task 2019-12-31T18:01:38.817Z] 18:01:38 ERROR - The mochitest suite: mochitest-remote ran with return status: FAILURE

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

When you check the error you will see that there are no tests to run:

No tests were found for flavor 'browser' and the following manifest filters:

Looks like we still try to include an empty manifest.

Comment 21

[Andreas Tolfsen ❲:ato❳]

It looks like the patch is working as intended, but that the M(remote) job fails in the beta simulation because it now rightly can’t find the tests.

I guess we need a second change to the TaskCluster job config to make sure it’s only triggered on the Nightly branch.

Comment 22

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1603930: taskcluster: run M(remote) on trunk, try only;

This prevents the Mochitest browser-chrome tests under remote/ from
running on integration branches, since the new Chromium-based remote
debugging protocol is not available there.

Comment 23

[Andreas Tolfsen ❲:ato❳]

Wrote a patch that disables M(remote) on integration branches. This seems to do the trick.

It is similar to Cosmin’s original patch, but disables the TaskCluster job rather than the test suite. I’d be open to the argument that we should adopt Cosmin’s patch instead.

Beta sim try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fbbc15dd67722fa6fa626fa367398fbc104d6e0

Regular try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=65272648b9402239c19c39dbeee1ab264ac6eeec

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

I would rather favorite Cosmin's patch, which makes it easier to spot check test results on other branches by just removing this line. Having to fiddle around with TC configs is rather more complex, and the appropriate lines hard to find.

Comment 25

[Andreas Tolfsen ❲:ato❳]

I’d be fine with that. I’ll rework the changeset to include it and verify with a new set of try pushes.

Comment 26

[Andreas Tolfsen ❲:ato❳]

Changeset updated to:

1. D58452 bug 1603930: toolkit: fix remote agent build targets
2. D57258 bug 1603930: remote: skip M(remote) tests on release_or_beta

Beta sim try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d9191503871b534482ef6c97925ea69902dc7a7

Regular try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac0b9bb0bc661af14d825661c7e694d110587468

Comment 27

[Andreas Tolfsen ❲:ato❳]

(In reply to Andreas Tolfsen ❲:ato❳ from comment #26)

Beta sim try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d9191503871b534482ef6c97925ea69902dc7a7

It doesn’t look like the skip-if = release_or_beta approach works when there are no tests in the manifest:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d9191503871b534482ef6c97925ea69902dc7a7&selectedJob=283202881

This is a bit annoying because I agree with whimboo when he said earlier that it is easier to spot check test manifests than understanding TaskCluster configurations.

Comment 28

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Looks like this happens because it disables all of the remote tests. As such we might have to do the Taskcluster change unless we want to add a no-op test. Maybe ask Aryx if there is another solution.

Comment 29

[Andreas Tolfsen ❲:ato❳]

Let’s just go with the TaskCluster option for now, disabling M(remote), in interest to make progress here.

Then I will ressurrect the more understandable skip-if = release_or_beta approach when I work on bug 1606604.

Regardless we need the first patch here to correct the enable/disable mishap I made back in April.

Beta sim try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c5ab80cce0c886144a85fae7266fdb82a9654b3

Regular try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=166d9de9567cf38f1ff8429f0413d2b99eb102e0

Comment 30

[Andreas Tolfsen ❲:ato❳]

Both try runs seem fine, let’s get this fixed.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405d6889de7c
toolkit: fix remote agent build targets; r=firefox-build-system-reviewers,mshal
https://hg.mozilla.org/integration/autoland/rev/cc2077051f23
taskcluster: run M(remote) on trunk, try only; r=whimboo

Comment 32

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/405d6889de7c
https://hg.mozilla.org/mozilla-central/rev/cc2077051f23

Comment 33

[Andreea Pavel [:apavel]]

Verified fixed in today's beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=65f0ca46cd7bb6e64c7b9f7374f68adb19f6f7f7

Comment 34

[Andreas Tolfsen ❲:ato❳]

Thanks Cosmin and Andreea!