Closed Bug 1603995 Opened 1 year ago Closed 1 year ago

Dead assignments in nsFrame::BoxReflow

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Version:
73 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: alexhenrie24, Assigned: alexhenrie24)

Details

Attachments

(1 file)

Bug 1603995 - Remove dead assignments from nsFrame::BoxReflow.
47 bytes, text/x-phabricator-request
Details | Review

The end of the nsFrame::BoxReflow function currently looks like this:

  if (aWidth == NS_UNCONSTRAINEDSIZE) aWidth = aDesiredSize.Width();

  if (aHeight == NS_UNCONSTRAINEDSIZE) aHeight = aDesiredSize.Height();

  metrics->mLastSize.width = aDesiredSize.Width();
  metrics->mLastSize.height = aDesiredSize.Height();

#ifdef DEBUG_REFLOW
  gIndent2--;
#endif
}

The assignments to aWidth and aHeight are pointless because the aWidth and aHeight variables are never used again. These assignments have been dead assignments since before Mozilla moved to Mercurial in 2007. I think it's safe to say that we don't need them anymore.

Assignee: nobody → alexhenrie24
Status: NEW → ASSIGNED
Pushed by dbaron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b7cd94eaf0a
Remove dead assignments from nsFrame::BoxReflow. r=dbaron

https://hg.mozilla.org/mozilla-central/rev/9b7cd94eaf0a

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox73: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.