Closed
Bug 1603995
Opened 4 years ago
Closed 4 years ago
Dead assignments in nsFrame::BoxReflow
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: alexhenrie24, Assigned: alexhenrie24)
Details
Attachments
(1 file)
The end of the nsFrame::BoxReflow function currently looks like this:
if (aWidth == NS_UNCONSTRAINEDSIZE) aWidth = aDesiredSize.Width();
if (aHeight == NS_UNCONSTRAINEDSIZE) aHeight = aDesiredSize.Height();
metrics->mLastSize.width = aDesiredSize.Width();
metrics->mLastSize.height = aDesiredSize.Height();
#ifdef DEBUG_REFLOW
gIndent2--;
#endif
}
The assignments to aWidth and aHeight are pointless because the aWidth and aHeight variables are never used again. These assignments have been dead assignments since before Mozilla moved to Mercurial in 2007. I think it's safe to say that we don't need them anymore.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → alexhenrie24
Status: NEW → ASSIGNED
Pushed by dbaron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9b7cd94eaf0a Remove dead assignments from nsFrame::BoxReflow. r=dbaron
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in
before you can comment on or make changes to this bug.
Description
•