1603995 - Dead assignments in nsFrame::BoxReflow

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Alex Henrie]

The end of the nsFrame::BoxReflow function currently looks like this:

  if (aWidth == NS_UNCONSTRAINEDSIZE) aWidth = aDesiredSize.Width();

  if (aHeight == NS_UNCONSTRAINEDSIZE) aHeight = aDesiredSize.Height();

  metrics->mLastSize.width = aDesiredSize.Width();
  metrics->mLastSize.height = aDesiredSize.Height();

#ifdef DEBUG_REFLOW
  gIndent2--;
#endif
}

The assignments to aWidth and aHeight are pointless because the aWidth and aHeight variables are never used again. These assignments have been dead assignments since before Mozilla moved to Mercurial in 2007. I think it's safe to say that we don't need them anymore.

Comment 1

[Alex Henrie]

Attachment: Bug 1603995 - Remove dead assignments from nsFrame::BoxReflow.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b7cd94eaf0a
Remove dead assignments from nsFrame::BoxReflow. r=dbaron

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9b7cd94eaf0a