1604009 - Dead assignments in nsGridRowGroupLayout::CountRowsColumns and nsGridRowGroupLayout::BuildRows

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Alex Henrie]

nsGridRowGroupLayout::CountRowsColumns currently has a loop that looks like this:

while (child) {
  // first see if it is a scrollframe. If so walk down into it and get the
  // scrolled child
  nsIFrame* deepChild = nsGrid::GetScrolledBox(child);

  nsIGridPart* monument = nsGrid::GetPartFromBox(deepChild);
  if (monument) {
    monument->CountRowsColumns(deepChild, aRowCount, aComputedColumnCount);
    child = nsBox::GetNextXULBox(child);
    deepChild = child;
    continue;
  }

  child = nsBox::GetNextXULBox(child);

  // if not a monument. Then count it. It will be a bogus row
  aRowCount++;
}

The assignment to deepChild before the continue statement is pointless because deepChild is always set at the beginning of the loop. This assignment has been a dead assignment since before Mozilla moved to Mercurial in 2007 and can be safely removed.

There is also a nearly-identical loop in nsGridRowGroupLayout::BuildRows with the same problem.

Comment 1

[Alex Henrie]

Attachment: Bug 1604009 - Remove dead assignments from nsGridRowGroupLayout functions.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e6a4e221495
Remove dead assignments from nsGridRowGroupLayout functions. r=dbaron

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7e6a4e221495