Use consistent initialization for IsLikelyConstructorWrapper flag
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file)
The js::BaseScript::ImmutableFlags::IsLikelyConstructorWrapper flag doesn't follow normal lazy/non-lazy initialization patterns and should be fixed. In practice, the current implementation is wrong for BinAST lazy-functions.
|
Assignee | |
Comment 1•4 years ago
|
||
This BaseScript flag should initialized in the same way as other flags. This
fixes lazy-function BinAST parsing to compute this flag correctly.
|
||
Updated•4 years ago
|
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52c86d6ee05b Fix IsLikelyConstructorWrapper flag initialization. r=arai
|
||
Comment 3•4 years ago
|
||
Backed out changeset 52c86d6ee05b (bug 1604069) for spidermonkey bustage failures at MacroAssembler.cpp
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=281393066&searchStr=cgc&revision=52c86d6ee05b74ad2c6e0b7964c3f24ea445a915
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281393066&repo=autoland&lineNumber=25443
Backout: https://hg.mozilla.org/integration/autoland/rev/5a695724c6a6c712fa4432f2b95225f397a61a95
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5a251a4de01b Fix IsLikelyConstructorWrapper flag initialization r=mgaudet
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•