1604158 - Auto-Detect submenu is shown when it shouldn't in hamburger menu and toolbar button

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:

1. Make sure Nightly is the latest version.
2. Make sure intl.charset.detector.ng.enabled is true (default). If intl.charset.detector.ng.enabled has no value, your Nightly is probably old, back to 1.
3. Select the hamburger menu > More > Text Encoding.

Actual result:
Auto-Detect submenu is shown which should not.

Expected result:
Auto-Detect submenu should be hidden.

Comment 1

[Masatoshi Kimura [:emk]]

Apparently this change only affects menu bar > View > Text Encoding.

Comment 2

[Masatoshi Kimura [:emk]]

This part should be hidden when intl.charset.detector.ng.enabled is true.

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1604158 - Hide the encoding detector submenu in hamburger/toolbar cases when chardetng is enabled.

Comment 4

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14123a2f7b27757248e7b1f4be5d46159e5929a4

Comment 5

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3af6ddc882e9d85eb48148d2847daf1af686457

(In reply to Masatoshi Kimura [:emk] from comment #2)

This part should be hidden when intl.charset.detector.ng.enabled is true.

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca0c893ca9f3
Hide the encoding detector submenu in hamburger/toolbar cases when chardetng is enabled. r=emk

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ca0c893ca9f3

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified using 73.0b3 (20200110003145) on Windows 10x64, macOS 10.15 and Ubuntu 16.04. While "intl.charset.detector.ng.enabled" is on true Auto-Detect submenu is not shown under hamburger menu > More > Text Encoding.