Closed Bug 1604158 Opened 1 year ago Closed 1 year ago

Auto-Detect submenu is shown when it shouldn't in hamburger menu and toolbar button

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla73
Tracking Status
firefox73 --- verified

People

(Reporter: emk, Assigned: hsivonen)

References

Details

Attachments

(1 file)

Steps to reproduce:

  1. Make sure Nightly is the latest version.
  2. Make sure intl.charset.detector.ng.enabled is true (default). If intl.charset.detector.ng.enabled has no value, your Nightly is probably old, back to 1.
  3. Select the hamburger menu > More > Text Encoding.

Actual result:
Auto-Detect submenu is shown which should not.

Expected result:
Auto-Detect submenu should be hidden.

Apparently this change only affects menu bar > View > Text Encoding.

Summary: Auto-Detect submenu is shown when it shouldn't → Auto-Detect submenu is shown when it shouldn't in hamburger menu and toolbar button

This part should be hidden when intl.charset.detector.ng.enabled is true.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3af6ddc882e9d85eb48148d2847daf1af686457

(In reply to Masatoshi Kimura [:emk] from comment #2)

This part should be hidden when intl.charset.detector.ng.enabled is true.

Thanks!

Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca0c893ca9f3
Hide the encoding detector submenu in hamburger/toolbar cases when chardetng is enabled. r=emk
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Flags: qe-verify+

Verified using 73.0b3 (20200110003145) on Windows 10x64, macOS 10.15 and Ubuntu 16.04. While "intl.charset.detector.ng.enabled" is on true Auto-Detect submenu is not shown under hamburger menu > More > Text Encoding.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.