Open Bug 1604202 Opened 5 years ago Updated 2 years ago

Intermittent devtools/client/netmonitor/test/browser_net_websocket_stacks.js | The attached url is correct. - Got http://example.com/browser/devtools/client/netmonitor/test/js_websocket-worker-test.js, expected ws://localhost:8080/

Categories

(DevTools :: Netmonitor, defect, P5)

defect

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: intermittent-bug-filer, Assigned: dimi)

References

(Regression)

Details

(Keywords: intermittent-failure, leave-open, regression, Whiteboard: [stockwell disabled])

Attachments

(2 files)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=281339007&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RmVfnNLuTZWHZcPGSZfqzg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RmVfnNLuTZWHZcPGSZfqzg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2019-12-16T12:07:41.672Z] 12:07:41 INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_websocket_stacks.js | Request #0 (document) has an empty stacktrace -
[task 2019-12-16T12:07:41.672Z] 12:07:41 INFO - > Verifying: GET ws://localhost:8080/ ({cause:{type:"websocket", loadingDocumentUri:"http://example.com/browser/devtools/client/netmonitor/test/html_websocket-test-page.html"}})
[task 2019-12-16T12:07:41.673Z] 12:07:41 INFO - Visible index of item: 1
[task 2019-12-16T12:07:41.673Z] 12:07:41 INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_websocket_stacks.js | The attached method is correct. -
[task 2019-12-16T12:07:41.674Z] 12:07:41 INFO - Buffered messages finished
[task 2019-12-16T12:07:41.674Z] 12:07:41 INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_websocket_stacks.js | The attached url is correct. - Got http://example.com/browser/devtools/client/netmonitor/test/js_websocket-worker-test.js, expected ws://localhost:8080/
[task 2019-12-16T12:07:41.674Z] 12:07:41 INFO - Stack trace:
[task 2019-12-16T12:07:41.675Z] 12:07:41 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2019-12-16T12:07:41.675Z] 12:07:41 INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/head.js:verifyRequestItemTarget:540
[task 2019-12-16T12:07:41.675Z] 12:07:41 INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/head.js:validateRequests/<:1083
[task 2019-12-16T12:07:41.676Z] 12:07:41 INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/head.js:validateRequests:1079
[task 2019-12-16T12:07:41.676Z] 12:07:41 INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_websocket_stacks.js:null:78
[task 2019-12-16T12:07:41.676Z] 12:07:41 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2019-12-16T12:07:41.677Z] 12:07:41 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2019-12-16T12:07:41.679Z] 12:07:41 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:919
[task 2019-12-16T12:07:41.679Z] 12:07:41 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2019-12-16T12:07:41.680Z] 12:07:41 INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_websocket_stacks.js | The displayed method is correct. -
[task 2019-12-16T12:07:41.680Z] 12:07:41 INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_websocket_stacks.js | The displayed file is correct. -
[task 2019-12-16T12:07:41.684Z] 12:07:41 INFO - Not taking screenshot here: see the one that was previously logged

Flags: needinfo?(jodvarko)
Regressed by: 765651
Summary: Intermittent TV devtools/client/netmonitor/test/browser_net_websocket_stacks.js | The attached url is correct. - Got http://example.com/browser/devtools/client/netmonitor/test/js_websocket-worker-test.js, expected ws://localhost:8080/ → Intermittent devtools/client/netmonitor/test/browser_net_websocket_stacks.js | The attached url is correct. - Got http://example.com/browser/devtools/client/netmonitor/test/js_websocket-worker-test.js, expected ws://localhost:8080/

The recent batch of failures is a regression from bug 1437626. Dimi, please investigate.

Flags: needinfo?(jodvarko) → needinfo?(dlee)
Regressed by: 1437626
Has Regression Range: --- → yes
Keywords: regression
Assignee: nobody → dlee
Status: NEW → ASSIGNED

There are 144 total failures in the last 7 days. I created a patch to disable this test in order to reduce the failure frequency.

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86dc1b71a184
Disabled browser_net_websocket_stacks.js on all platforms. r=jmaher
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

I can reproduce this in my local build without the patch in bug 1437626. I think the patch in bug 1437626 may affect the timing we trigger network events so the testcase fails more frequently now.
If I understand correctly, the test expects a fixed order of network events[1][2], which isn't true sometimes.

Hi Alexandre,
Since you reviewed the testcase, I would like to know if you or someone you know can help investigate this issue. I am not very familiar with that part so not quite sure how to fix it. Thanks!

[1] https://searchfox.org/mozilla-central/rev/89814940895946b48b4c04c702efd2c676ec8e7e/devtools/client/netmonitor/test/browser_net_websocket_stacks.js#13-48
[2] https://searchfox.org/mozilla-central/rev/89814940895946b48b4c04c702efd2c676ec8e7e/devtools/client/netmonitor/test/head.js#1181-1192

Flags: needinfo?(dlee) → needinfo?(poirot.alex)

I'm on PTO, forwarding to bomsy.

Flags: needinfo?(poirot.alex) → needinfo?(hmanilla)

Hello Dimi,
Thanks for looking at this.
Yes you are correct the test expects that the network events should be in an expected order, but that does not seem to be the case sometimes.

I've confirmed with the necko team that the platform does not guarantee the order of the requests.
So we should refactor the test to not depend on the order.

I'll have a patch to fix in a bit

Thanks

Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/944ef50a7278
Remove the dependency on the order of the network events r=Honza
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: