Closed Bug 1604304 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 20795 - [css-pseudo] Recalculate viewport units in ::marker

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20795 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20795
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-pseudo] Recalculate viewport units in ::marker

If a marker uses viewport units (vw or vh), they should be recalculated
when the size of the viewport changes.

This patch updates node traversal methods to include ::marker, so that
it's taken into account when updating viewport units.

However, this is only fixed for markers with non-normal content, since
otherwise they aren't implemented as real pseudo-elements yet.

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-content-014.html

The test still fails because it includes cases with 'content: normal'.

Change-Id: I7495dd5c4bbd84d6286635a63199bfcc663c62c9
Reviewed-on: https://chromium-review.googlesource.com/1970015
WPT-Export-Revision: ccd3f9473fb9c8f1a7b8b3b792acd84287875f6e

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db02d80617d2
[wpt PR 20795] - [css-pseudo] Recalculate viewport units in ::marker, a=testonly
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.