1604375 - The ReadableStreamTee algorithm isn't up-to-date with the spec

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Jeff Walden [:Waldo]]

Our ReadableStreamTee algorithm doesn't match the current spec -- ours doesn't have a reading variable, our ReadableStreamTee_Pull bears not much relation to the current algorithm, etc. I'm going to update it to current spec. (I don't know how observable our differences from the current spec are. It's at least possible the distinctions are editorial, but the extent of differences in the pull algorithm suggests otherwise to me.)

(This also has the side effect of familiarizing me with the tactics used to implement teeing, tactics that I expect should carry over to implementation tactics for implementing ReadableStream.prototype.pipeTo.)

Comment 1

[Jeff Walden [:Waldo]]

https://github.com/whatwg/streams/commit/6f94580f6731d1e017c516af097d47c45aad1f56 appears to be much of the difference between our algorithm and the current algorithm, and the changes made there are not merely editorial. So the issues to fix here are observable.

Comment 2

[Jeff Walden [:Waldo]]

Most of a patch done, but https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e256851af7b83156e213df10dc2290ac7c80618 suggests a wpt update is needed, or wpt tests are out of date, or something unobvious is up. Still need to investigate.

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Bug 1604375 - Rename |RunResolutionFunction| to |RunSettlingFunction|, because "resolution" is sort of like "resolve" but this function handles both resolve and reject functions so it's misnomerish. r=arai

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Bug 1604375 - Split |RunSettlingFunction| into |RunFulfillFunction| and |RunRejectFunction|. r=arai

Depends on D58845

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Bug 1604375 - Implement |JS::AddPromiseReactionsIgnoringUnhandledRejection| that won't report an unhandled rejection if the passed-in-promise rejects. r=arai

Depends on D58846

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Bug 1604375 - Update |ReadableStreamTee| to latest spec. r=arai

Depends on D58847

Comment 8

[Jeff Walden [:Waldo]]

Attachment: Bug 1604375 - Rename |SetPromiseIsHandled| to |SetSettledPromiseIsHandled|, as the function can only be used on settled promises. r=arai

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0374840e1484
Rename |SetPromiseIsHandled| to |SetSettledPromiseIsHandled|, as the function can only be used on settled promises.  r=arai
https://hg.mozilla.org/integration/autoland/rev/77f8c50c3a5f
Rename |RunResolutionFunction| to |RunSettlingFunction|, because "resolution" is sort of like "resolve" but this function handles both resolve and reject functions so it's misnomerish.  r=arai
https://hg.mozilla.org/integration/autoland/rev/677c66a198eb
Split |RunSettlingFunction| into |RunFulfillFunction| and |RunRejectFunction|.  r=arai
https://hg.mozilla.org/integration/autoland/rev/e37d4d3ab131
Implement |JS::AddPromiseReactionsIgnoringUnhandledRejection| that won't report an unhandled rejection if the passed-in-promise rejects.  r=arai
https://hg.mozilla.org/integration/autoland/rev/ba76b651e79f
Update |ReadableStreamTee| to latest spec.  r=arai

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0374840e1484
https://hg.mozilla.org/mozilla-central/rev/77f8c50c3a5f
https://hg.mozilla.org/mozilla-central/rev/677c66a198eb
https://hg.mozilla.org/mozilla-central/rev/e37d4d3ab131
https://hg.mozilla.org/mozilla-central/rev/ba76b651e79f