Closed Bug 1604405 Opened 2 years ago Closed 2 years ago

Replace gamepad button array index with axis array index in Mac OS.

Categories

(Core :: DOM: Device Interfaces, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox72 --- wontfix
firefox73 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(1 file)

I did a mistake when selecting the axis index at https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/dom/gamepad/cocoa/CocoaGamepad.cpp#137. We should use the axis array instead of the button array.

Assignee: nobody → dmu
Priority: -- → P1
Depends on: 1593841
Summary: Replace button array index with axis array index in Mac OS. → Replace gamepad button array index with axis array index in Mac OS.
Blocks: 1593841
No longer depends on: 1593841
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5506150ba242
Replace gamepad button array index with axis array index in Mac OS. r=baku
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Does this need a Beta approval request to go with bug 1593841?

Flags: needinfo?(dmu)

Comment on attachment 9116309 [details]
Bug 1604405 - Replace gamepad button array index with axis array index in Mac OS.

Beta/Release Uplift Approval Request

  • User impact if declined: This fix comes with Bug 1593841. If we uplift the patch of Bug 1593841, we need to uplift it as well. Otherwise, Bug 1593841 will cause crashes in Beta.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1593841
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It fixes the mistake from Bug 1593841 and adds more conditional checks.
  • String changes made/needed:
Flags: needinfo?(dmu)
Attachment #9116309 - Flags: approval-mozilla-beta?

(In reply to Ryan VanderMeulen [:RyanVM][PTO Dec 21 - Jan 1] from comment #4)

Does this need a Beta approval request to go with bug 1593841?

Yes. Let's do it.

Comment on attachment 9116309 [details]
Bug 1604405 - Replace gamepad button array index with axis array index in Mac OS.

This is a very low volume crash, we only have one beta build left (tonight).
I think we can let the fix for this ride with 73.

Attachment #9116309 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.