1604405 - Replace gamepad button array index with axis array index in Mac OS.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[Daosheng Mu[:daoshengmu]]

I did a mistake when selecting the axis index at https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/dom/gamepad/cocoa/CocoaGamepad.cpp#137. We should use the axis array instead of the button array.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1604405 - Replace gamepad button array index with axis array index in Mac OS.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5506150ba242
Replace gamepad button array index with axis array index in Mac OS. r=baku

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/5506150ba242

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta approval request to go with bug 1593841?

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 9116309 [details]
Bug 1604405 - Replace gamepad button array index with axis array index in Mac OS.

Beta/Release Uplift Approval Request

• User impact if declined: This fix comes with Bug 1593841. If we uplift the patch of Bug 1593841, we need to uplift it as well. Otherwise, Bug 1593841 will cause crashes in Beta.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1593841
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It fixes the mistake from Bug 1593841 and adds more conditional checks.
• String changes made/needed:

Comment 6

[Daosheng Mu[:daoshengmu]]

(In reply to Ryan VanderMeulen [:RyanVM][PTO Dec 21 - Jan 1] from comment #4)

Does this need a Beta approval request to go with bug 1593841?

Yes. Let's do it.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9116309 [details]
Bug 1604405 - Replace gamepad button array index with axis array index in Mac OS.

This is a very low volume crash, we only have one beta build left (tonight).
I think we can let the fix for this ride with 73.