1604411 - Display variables declared in the expression in the autocomplete popup

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Given the following expression in the console input

var win = window;
wi

The autocomplete popup should display both win and window.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1604411 - Add expression variables in autocomplete popup. r=Honza.

Variables are retrieved from CodeMirror state and sent to the
webconsole actor, where the filtering is done.

Depends on D57342

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

The attached patch works quite well, with one limitation: when in a function, it does not autocomplete the function parameters.
I'm not sure if I'm doing something wrong or if it's a codeMirror limitation.
I asked the question on https://discuss.codemirror.net/t/function-parameter-autocomplete/2240

This isn't too bad though, and we could probably fix that in a follow up.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)

The attached patch works quite well, with one limitation: when in a function, it does not autocomplete the function parameters.
I'm not sure if I'm doing something wrong or if it's a codeMirror limitation.
I asked the question on https://discuss.codemirror.net/t/function-parameter-autocomplete/2240

This isn't too bad though, and we could probably fix that in a follow up.

Needed to look into the state context too. Now it works fine :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccb4dd2108ce
Add expression variables in autocomplete popup. r=Honza.

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ccb4dd2108ce