Closed Bug 1604467 Opened 2 years ago Closed 2 years ago

Remove SRC_TRY source note

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

This is the only source note still used by the JITs (BytecodeAnalysis and IonBuilder). I think this after-try offset should be stored as JSOP_TRY operand instead and then JIT compilation never needs to look up source notes, which seems nice.

We can then remove IonBuilder::gsn and the gsnCache in BytecodeAnalysis::init.

Priority: -- → P2

JIT compilation and bytecode analysis now no longer depend on any source notes.

The deleted code to print the offset-to-catch in Disassemble1 goes back to
bug 680228, before the newer code coverage implementation. It's unlikely that
anyone is still depending on this and it's also confusing to print an offset
in the bytecode disassembly that's not actually an operand.

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a590ca97f139
Replace SRC_TRY source note with a JSOP_TRY bytecode operand. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.