1604485 - Add linter rule against loading client files in devtools/shared.

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1591013.

Files in devtools/shared might be loaded on mobile Firefox where devtools/client is not available. So we should prevent from loading client modules in those files. A notable exception are fronts files. Those files are loaded only on the client and may load client modules.

We can simply exclude shared/fronts for now. This would have caught the mobile debugging regression in Bug 1602800, so I think it can be useful.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1604485 - Add eslint rule against requiring client files from devtools/shared

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/986025e43845
Add eslint rule against requiring client files from devtools/shared r=nchevobbe

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/986025e43845

Comment 4

[Julien Wajsberg [:julienw]]

Thanks, we also got bitten by this recently!