Closed Bug 1604514 Opened 8 months ago Closed 7 months ago

Service Workers: zombie breakpoint

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(firefox74 fixed)

RESOLVED FIXED
Firefox 74
Tracking Status
firefox74 --- fixed

People

(Reporter: Honza, Assigned: bhackett1024)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR:

  1. Open DevTools Toolbox, select the Debugger panel
  2. Load this page: http://janodvarko.cz/tests/debugger/service-workers/
  3. Click Register Worker in test case #1
  4. Create BP in service-worker.js on line 33 console.log("install", event)
  5. Click Unregister Worker in test case #1
  6. Click Register Worker in test case #1
  7. The debugger pauses on line 33, but the BP isn't displayed (the blue marker isn't there)

Honza

Priority: P3 → P2

The problem here is related to how we treat service worker sources separately from one another, so that we can have multiple tabs with different versions of the source for different workers. When we unregister and re-register the service worker, the debugger client has a new source, and the pending breakpoints logic has some logic that prevents the breakpoint from being applied to the new service worker source. This logic is pretty weird and I tried removing it in bug 1534786, but it caused jest failures so I left it alone. Those jest failures don't seem to be happening anymore so hopefully we can just simplify the pending breakpoints logic and fix this bug in the meantime.

Assignee: nobody → bhackett1024
Status: NEW → ASSIGNED
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ffb6c6fcbc0
Remove special case when applying pending breakpoints, r=loganfsmyth.
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
QA Whiteboard: [qa-74b-p2]
You need to log in before you can comment on or make changes to this bug.