1604536 - mozext failing with Python 3

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[Marco Castelluccio [:marco]]

hglib.error.ServerError: server exited with status 1: b'** unknown exception encountered, please report by visiting
** https://mercurial-scm.org/wiki/BugTracker
** Python 3.7.4 (default, Oct 17 2019, 06:10:02) [GCC 8.3.0]
** Mercurial Distributed SCM (version 5.2)
** Extensions loaded: purge, strip, robustcheckout, hgmo, pushlog, mozext, firefoxtree, share
Traceback (most recent call last):
  File "/usr/local/bin/hg", line 36, in <module>
    dispatch.run()
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 111, in run
    status = dispatch(req)
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 250, in dispatch
    ret = _runcatch(req) or 0
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 424, in _runcatch
    return _callcatch(ui, _runcatchfunc)
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 433, in _callcatch
    return scmutil.callcatch(ui, func)
  File "/usr/local/lib/python3.7/site-packages/mercurial/scmutil.py", line 177, in callcatch
    return func()
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 414, in _runcatchfunc
    return _dispatch(req)
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 1174, in _dispatch
    lui, repo, cmd, fullargs, ui, options, d, cmdpats, cmdoptions
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 862, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 1185, in _runcommand
    return cmdfunc()
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 1171, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/usr/local/lib/python3.7/site-packages/mercurial/util.py", line 1843, in check
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mercurial/util.py", line 1843, in check
    return func(*args, **kwargs)
  File "/version-control-tools/hgext/hgmo/__init__.py", line 597, in servehgmo
    return orig(ui, repo, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mercurial/util.py", line 1843, in check
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mercurial/commands.py", line 6495, in serve
    return server.runservice(opts, initfn=service.init, runfn=service.run)
  File "/usr/local/lib/python3.7/site-packages/mercurial/server.py", line 164, in runservice
    return runfn()
  File "/usr/local/lib/python3.7/site-packages/mercurial/commandserver.py", line 429, in run
    return sv.serve()
  File "/usr/local/lib/python3.7/site-packages/mercurial/commandserver.py", line 363, in serve
    while self.serveone():
  File "/usr/local/lib/python3.7/site-packages/mercurial/commandserver.py", line 337, in serveone
    handler(self)
  File "/usr/local/lib/python3.7/site-packages/mercurial/commandserver.py", line 321, in runcommand
    ret = dispatch.dispatch(req) & 255
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 250, in dispatch
    ret = _runcatch(req) or 0
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 424, in _runcatch
    return _callcatch(ui, _runcatchfunc)
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 433, in _callcatch
    return scmutil.callcatch(ui, func)
  File "/usr/local/lib/python3.7/site-packages/mercurial/scmutil.py", line 177, in callcatch
    return func()
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 414, in _runcatchfunc
    return _dispatch(req)
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 1174, in _dispatch
    lui, repo, cmd, fullargs, ui, options, d, cmdpats, cmdoptions
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 862, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 1185, in _runcommand
    return cmdfunc()
  File "/usr/local/lib/python3.7/site-packages/mercurial/dispatch.py", line 1171, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/usr/local/lib/python3.7/site-packages/mercurial/util.py", line 1843, in check
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mercurial/util.py", line 1843, in check
    return func(*args, **kwargs)
  File "/version-control-tools/hgext/firefoxtree/__init__.py", line 484, in pullcommand
    return orig(ui, repo, source=source, **opts)
  File "/usr/local/lib/python3.7/site-packages/mercurial/util.py", line 1843, in check
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/mercurial/commands.py", line 5453, in pull
    opargs=pullopargs,
  File "/version-control-tools/hgext/mozext/__init__.py", line 587, in wrappedpull
    repo._update_remote_refs(remote, tree)
  File "/version-control-tools/hgext/mozext/__init__.py", line 1460, in _update_remote_refs
    if tree not in TREE_ALIASES[\'releases\']:
KeyError: \'releases\''

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/fa93e7223185
mozext: use byte-string as key to TREE_ALIASES

Comment 2

[Connor Sheehan [:sheehan]]

Can you update again with the above fix and let me know if things are working again? Let's re-open until we confirm you can move forward.

mozext test coverage is awful. I've been trying to improve things here but there are still gaps.

Comment 3

[Marco Castelluccio [:marco]]

Trying to verify, but the clone is currently failing:

hglib.error.CommandError: (255, b'ensuring https://hg.mozilla.org/mozilla-central@tip is available at /cache/mozilla-central
(sharing from new pooled repository 8ba995b74e18334ab3707f27e9eb8f4e37ba3d29)
applying clone bundle from https://storage.googleapis.com/moz-hg-bundles-gcp-us-central1/mozilla-central/c238b47d7d57e651a92b4f134641fa694e4ea900.packed1.hg
552622 files to transfer, 2.72 GB of data
PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["projects/757942385826/machineTypes/n1-standard-4"], "lowerIsBetter": true, "name": "clone_errored", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 1.0167551040649414}, {"extraOptions": ["projects/757942385826/machineTypes/n1-standard-4"], "lowerIsBetter": true, "name": "overall", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 1.703268051147461}, {"extraOptions": ["projects/757942385826/machineTypes/n1-standard-4"], "lowerIsBetter": true, "name": "overall_pull", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 1.703268051147461}, {"extraOptions": ["projects/757942385826/machineTypes/n1-standard-4"], "lowerIsBetter": true, "name": "overall_pull_fullcheckout", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 1.703268051147461}, {"extraOptions": ["projects/757942385826/machineTypes/n1-standard-4"], "lowerIsBetter": true, "name": "overall_pull_populatedwdir", "serverUrl": "hg.mozilla.org", "shouldAlert": false, "subtests": [], "value": 1.703268051147461}]}', b"(using Mercurial 5.2)
abort: unexpected response from remote server:
'data/accessible/ipc/win/handler/AccessibleHandlerControl.cpp.i\\x0048data/accessible/ipc/win/handler/AccessibleHandlerControl.cpp.i\\x004875\
'")

It was not failing earlier at this point, maybe it's an intermittent issue. Or something else happened in the meantime.

Comment 4

[Marco Castelluccio [:marco]]

<hg-deploy-bot> Started deploy of revision 81d7222a9df0 to hg.mozilla.org; previous a5287648b414.
<hg-deploy-bot> Finished deploy of hooks and extensions to hg.mozilla.org a few minutes before this new error.
Might be related.

Comment 5

[Marco Castelluccio [:marco]]

It's failing with Python 2 too, so there's something broken on the server side. Maybe a bad clone bundle?

Comment 6

[Connor Sheehan [:sheehan]]

I tested a clone with a Python2 Mercurial 5.2.1 on a GCE instance and it seemed to work without issue (verified that the same bundle as shown in your stack trace was downloaded and checked out). There was a minor problem with clonebundles this evening, which may have interfered with the process. I've rolled back to the previous bundle in the hopes that it fixes the issues you're seeing. Let me know if the problem persists.

Comment 7

[Marco Castelluccio [:marco]]

Great, thanks. It's now working with an old image with Python 2 and Mercurial 5.1.

robustcheckout is still failing with Python 3 and Mercurial 5.2, but I'll file a separate bug for that as I can confirm this bug is fixed.