Closed Bug 1604661 Opened 4 years ago Closed 4 years ago

Add explicit thread filter "*" to select all registered threads

Categories

(Core :: Gecko Profiler, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozbugz, Assigned: mozbugz)

References

Details

Attachments

(1 file)

Currently the only way to select all registered threads (apart from manually enumerating all of them) is to enter "," (a single comma, or at least a final comma in the list), which tricks the thread-selection algorithm to match anything.
But this is definitely not user-friendly, and the popup helpfully removes this single comma when entered.

So we should have a more explicit way to select everything, and the usual token is * (asterisk).

The only way to select all registered threads was to have an empty entry in the
filter list, usually by just having "," (a single comma).
The popup removes spurious empty items, making this impossible for most users.

It is now possible to just have "*" (as the whole filter string, or at least one
item in the list) to select all registered threads.

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d01497500a3
Gecko Profiler filter "*" selects all registered threads - r=gregtatum
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: