1604664 - Enforce the WebRender shaders to be bound after the blend changes

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Dzmitry Malyshau [:kvark]]

The Renderer currently issues set_blend mixed with Shader::bind. The blending is mostly set up first, but not every time. This comes up as a problem for the next-gen APIs where the blending and the shader are both a part of the pipeline state, and we don't want to eagerly be setting the new pipeline on the change of either.

What we could do is to enforce (.e.g. by a debug-only runtime flag) that there is always a call to bind a shader between a blend setting and a draw call. This would allow the Szeged team to unconditionally change the pipeline on the shader binding. See https://github.com/szeged/webrender/pull/342

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: WR force program rebinding after blend changes

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b96d1241d11
WR force program rebinding after blend changes r=gw

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8b96d1241d11