1604717 - Skype installer download error: "dmg.part could not be saved, because the source file could not be read"

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

[Tracking Requested - why for this release]:

Matt, this is a regression in 73 Nightly from your DocumentChannel bug 1574372. It prevents me from downloading the Skype installer.

Steps to reproduce

1. Open https://www.skype.com/en/get-skype/
2. Click the "Get Skype for Mac" (or whatever)
3. Firefox will download the Skype installer .dmg and try to open it in the Disk Mounter helper app.

Expected result

The Skype installer .dmg should be downloaded.

Actual result

An error message reporting "/Users/chris/Downloads/H2LbGtVx.dmg.part could not be saved, because the source file could not be read." See the attached screenshot.

I bisected this regression to the following pushlog, which points to DocumentChannel bug 1574372:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=90cf0ce6c916dc56b5b5c0577f468fc5c4e89745&tochange=d9958362b9bd30f00a64627cb6041df808068cb9

Comment 1

[Matt Woodrow (:mattwoodrow)]

I think the navigation to the 'thank for downloading' is cancelling the existing load for the docshell, which is the download. Need to make sure we disconnect that option when we hand off to the download service.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Am I right that DocumentChannel isn't riding past Nightly for 73?

Comment 3

[Matt Woodrow (:mattwoodrow)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)

Am I right that DocumentChannel isn't riding past Nightly for 73?

We would like it to ride for 73! We have QA looking into it now.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

FYI, I hit this on Windows too. AFAICT, it affects any attempts to download (though Right Click...Save Link As still works).

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1604717 - Add more DocumentLoadListener logging. r?jya

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1604717 - Remove unused Suspend/Restore methods from DocumentLoadListener. r?jya

Depends on D57670

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1604717- Ensure that we can no longer receive cancellations from the content process DocumentChannelChild after we've decided to disconnect it. r?jya

Depends on D57671

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1604717 - Disconnect content process immediately when we handle a request as a download. r?bzbarsky

Depends on D57672

Comment 9

[Matt Woodrow (:mattwoodrow)]

Will spend some time today figuring out how to test this.

Comment 10

[:Gijs (out for now; he/him)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #9)

Will spend some time today figuring out how to test this.

FWIW, I added a tests at https://searchfox.org/mozilla-central/source/browser/base/content/test/general/browser_save_link_when_window_navigates.js and https://searchfox.org/mozilla-central/source/browser/components/downloads/test/browser/browser_iframe_gone_mid_download.js when fixing bug 1128480 and bug 1115248 that it should be possible to modify to catch this - in fact, I'm a little surprised the former didn't (though I haven't looked to see why not).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0407a056cb
Add more DocumentLoadListener logging. r=jya
https://hg.mozilla.org/integration/autoland/rev/a1e8bea2af43
Remove unused Suspend/Restore methods from DocumentLoadListener. r=jya
https://hg.mozilla.org/integration/autoland/rev/14f8d5866076
Ensure that we can no longer receive cancellations from the content process DocumentChannelChild after we've decided to disconnect it. r=jya
https://hg.mozilla.org/integration/autoland/rev/92e26fa16ba8
Disconnect content process immediately when we handle a request as a download. r=bzbarsky

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6f0407a056cb
https://hg.mozilla.org/mozilla-central/rev/a1e8bea2af43
https://hg.mozilla.org/mozilla-central/rev/14f8d5866076
https://hg.mozilla.org/mozilla-central/rev/92e26fa16ba8

Comment 15

[Alin Ilea, Desktop Test Engineering]

I have managed to reproduce the issue with an old Nightly build 73.0a1 (Build id: 20191217161753).
Verified - fixed on latest Nightly 73.0a1 (Build id: 20191229212642) using Windows 10, Mac OS 10.14 and Ubuntu 18.04.

Comment 16

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.

Comment 17

[Nhi Nguyen (:nhi)]

NI Matt for RCA.